feature #29186 [HttpKernel] Increase priority of AddRequestFormatsListener (thewilkybarkid)

fabpot · fabpot · commit 2ce6a34881c4 · 2019-01-02T11:02:59.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpKernel] Increase priority of AddRequestFormatsListener | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19469 | License | MIT | Doc PR | Currently `AddRequestFormatsListener` has a low priority, so it won't fire before others like `RouterListener` which can create problems (eg when listening for a HTTP exception thrown by the router you don't have access for any custom types). IMO this map should be in the application rather than set on every request, but the same can be achieved by giving it a high priority. (Can't think of a reason for it to not be first...) Commits ------- 9bf3136 Increase priority of AddRequestFormatsListener
diff --git a/src/Symfony/Component/HttpKernel/CHANGELOG.md b/src/Symfony/Component/HttpKernel/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.3.0
+-----
+
+ * increased the priority of `Symfony\Component\HttpKernel\EventListener\AddRequestFormatsListener`
+
 4.2.0
 -----
 
diff --git a/src/Symfony/Component/HttpKernel/EventListener/AddRequestFormatsListener.php b/src/Symfony/Component/HttpKernel/EventListener/AddRequestFormatsListener.php
@@ -45,6 +45,6 @@ public function onKernelRequest(GetResponseEvent $event)
      */
     public static function getSubscribedEvents()
     {
-        return array(KernelEvents::REQUEST => array('onKernelRequest', 1));
+        return array(KernelEvents::REQUEST => array('onKernelRequest', 100));
     }
 }
diff --git a/src/Symfony/Component/HttpKernel/Tests/EventListener/AddRequestFormatsListenerTest.php b/src/Symfony/Component/HttpKernel/Tests/EventListener/AddRequestFormatsListenerTest.php
@@ -46,7 +46,7 @@ public function testIsAnEventSubscriber()
     public function testRegisteredEvent()
     {
         $this->assertEquals(
-            array(KernelEvents::REQUEST => array('onKernelRequest', 1)),
+            array(KernelEvents::REQUEST => array('onKernelRequest', 100)),
             AddRequestFormatsListener::getSubscribedEvents()
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,6 @@ public function onKernelRequest(GetResponseEvent $event)`
`45`	`45`	`*/`
`46`	`46`	`public static function getSubscribedEvents()`
`47`	`47`	`{`
`48`		`- return array(KernelEvents::REQUEST => array('onKernelRequest', 1));`
	`48`	`+ return array(KernelEvents::REQUEST => array('onKernelRequest', 100));`
`49`	`49`	`}`
`50`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public function testIsAnEventSubscriber()`
`46`	`46`	`public function testRegisteredEvent()`
`47`	`47`	`{`
`48`	`48`	`$this->assertEquals(`
`49`		`- array(KernelEvents::REQUEST => array('onKernelRequest', 1)),`
	`49`	`+ array(KernelEvents::REQUEST => array('onKernelRequest', 100)),`
`50`	`50`	`AddRequestFormatsListener::getSubscribedEvents()`
`51`	`51`	`);`
`52`	`52`	`}`