bug #12548 [Form] fixed a maxlength overring on a guessing (origaminal)

fabpot · fabpot · commit 1cd4d4804e5b · 2014-12-12T08:47:05.000+01:00
This PR was squashed before being merged into the 2.5 branch (closes #12548). Discussion ---------- [Form] fixed a maxlength overring on a guessing | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11527 | License | MIT | Doc PR | - Commits ------- 7248680 [Form] fixed a maxlength overring on a guessing
diff --git a/src/Symfony/Component/Form/FormFactory.php b/src/Symfony/Component/Form/FormFactory.php
@@ -113,11 +113,11 @@ public function createBuilderForProperty($class, $property, $data = null, array
         $pattern = $patternGuess ? $patternGuess->getValue() : null;
 
         if (null !== $pattern) {
-            $options = array_merge(array('attr' => array('pattern' => $pattern)), $options);
+            $options = array_replace_recursive(array('attr' => array('pattern' => $pattern)), $options);
         }
 
         if (null !== $maxLength) {
-            $options = array_merge(array('attr' => array('maxlength' => $maxLength)), $options);
+            $options = array_replace_recursive(array('attr' => array('maxlength' => $maxLength)), $options);
         }
 
         if ($requiredGuess) {
diff --git a/src/Symfony/Component/Form/Tests/FormFactoryTest.php b/src/Symfony/Component/Form/Tests/FormFactoryTest.php
@@ -504,6 +504,41 @@ public function testCreateBuilderUsesMaxLengthIfFound()
         $this->assertEquals('builderInstance', $this->builder);
     }
 
+    public function testCreateBuilderUsesMaxLengthAndPattern()
+    {
+        $this->guesser1->expects($this->once())
+            ->method('guessMaxLength')
+            ->with('Application\Author', 'firstName')
+            ->will($this->returnValue(new ValueGuess(
+                20,
+                Guess::HIGH_CONFIDENCE
+            )));
+
+        $this->guesser2->expects($this->once())
+            ->method('guessPattern')
+            ->with('Application\Author', 'firstName')
+            ->will($this->returnValue(new ValueGuess(
+                '.{5,}',
+                Guess::HIGH_CONFIDENCE
+            )));
+
+        $factory = $this->getMockFactory(array('createNamedBuilder'));
+
+        $factory->expects($this->once())
+            ->method('createNamedBuilder')
+            ->with('firstName', 'text', null, array('attr' => array('maxlength' => 20, 'pattern' => '.{5,}', 'class' => 'tinymce')))
+            ->will($this->returnValue('builderInstance'));
+
+        $this->builder = $factory->createBuilderForProperty(
+            'Application\Author',
+            'firstName',
+            null,
+            array('attr' => array('class' => 'tinymce'))
+        );
+
+        $this->assertEquals('builderInstance', $this->builder);
+    }
+
     public function testCreateBuilderUsesRequiredSettingWithHighestConfidence()
     {
         $this->guesser1->expects($this->once())

Original file line number	Diff line number	Diff line change
`@@ -113,11 +113,11 @@ public function createBuilderForProperty($class, $property, $data = null, array`
`113`	`113`	`$pattern = $patternGuess ? $patternGuess->getValue() : null;`
`114`	`114`
`115`	`115`	`if (null !== $pattern) {`
`116`		`- $options = array_merge(array('attr' => array('pattern' => $pattern)), $options);`
	`116`	`+ $options = array_replace_recursive(array('attr' => array('pattern' => $pattern)), $options);`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`if (null !== $maxLength) {`
`120`		`- $options = array_merge(array('attr' => array('maxlength' => $maxLength)), $options);`
	`120`	`+ $options = array_replace_recursive(array('attr' => array('maxlength' => $maxLength)), $options);`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`if ($requiredGuess) {`