[Filesystem] deprecate chmod support in dumpFile()

xabbuh · xabbuh · commit 1a09c6a2ab4d · 2015-04-23T23:39:40.000+02:00
The ability to support a custom permission mask in the `dumpFile()`
method is deprecated since Symfony Symfony 2.3.12. This commit adds the
`error_trigger()` call if a custom permission mask is passed.
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -480,6 +480,10 @@ public function dumpFile($filename, $content, $mode = 0666)
 
         $this->rename($tmpFile, $filename, true);
         if (null !== $mode) {
+            if (func_num_args() > 2) {
+                trigger_error('Support for modifying file permissions is deprecated since version 2.3.12 and will be removed in 3.0.', E_USER_DEPRECATED);
+            }
+
             $this->chmod($filename, $mode);
         }
     }
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -959,6 +959,19 @@ public function testDumpFile()
     {
         $filename = $this->workspace.DIRECTORY_SEPARATOR.'foo'.DIRECTORY_SEPARATOR.'baz.txt';
 
+        $this->filesystem->dumpFile($filename, 'bar');
+
+        $this->assertFileExists($filename);
+        $this->assertSame('bar', file_get_contents($filename));
+    }
+
+    /**
+     * @group legacy
+     */
+    public function testDumpFileAndSetPermissions()
+    {
+        $filename = $this->workspace.DIRECTORY_SEPARATOR.'foo'.DIRECTORY_SEPARATOR.'baz.txt';
+
         $this->filesystem->dumpFile($filename, 'bar', 0753);
 
         $this->assertFileExists($filename);

Original file line number	Diff line number	Diff line change
`@@ -480,6 +480,10 @@ public function dumpFile($filename, $content, $mode = 0666)`
`480`	`480`
`481`	`481`	`$this->rename($tmpFile, $filename, true);`
`482`	`482`	`if (null !== $mode) {`
	`483`	`+ if (func_num_args() > 2) {`
	`484`	`+ trigger_error('Support for modifying file permissions is deprecated since version 2.3.12 and will be removed in 3.0.', E_USER_DEPRECATED);`
	`485`	`+ }`
	`486`	`+`
`483`	`487`	`$this->chmod($filename, $mode);`
`484`	`488`	`}`
`485`	`489`	`}`