bug #29344 Fixes sprintf(): Too few arguments in Translator (stephanedelprat)

nicolas-grekas · nicolas-grekas · commit 12e1c9b9e591 · 2018-11-27T08:20:38.000+01:00
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29344). Discussion ---------- Fixes sprintf(): Too few arguments in Translator | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | related to a previous deprecation  | Tests pass? | ? | Fixed tickets | none | License | MIT | Doc PR | none Fixes the log produced when the method is called : Before : "sprintf(): Too few arguments" After : "The "Symfony\Component\Translation\Translator::transChoice()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter." Reference : http://php.net/manual/function.sprintf.php Commits ------- 45c3de0 Fixes sprintf(): Too few arguments in Translator
diff --git a/src/Symfony/Component/Translation/Translator.php b/src/Symfony/Component/Translation/Translator.php
@@ -226,7 +226,7 @@ public function trans($id, array $parameters = array(), $domain = null, $locale
      */
     public function transChoice($id, $number, array $parameters = array(), $domain = null, $locale = null)
     {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%%count%%" parameter.', __METHOD__), E_USER_DEPRECATED);
 
         if (!$this->formatter instanceof ChoiceMessageFormatterInterface) {
             throw new LogicException(sprintf('The formatter "%s" does not support plural translations.', \get_class($this->formatter)));

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ public function trans($id, array $parameters = array(), $domain = null, $locale`
`226`	`226`	`*/`
`227`	`227`	`public function transChoice($id, $number, array $parameters = array(), $domain = null, $locale = null)`
`228`	`228`	`{`
`229`		`- @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter.', __METHOD__), E_USER_DEPRECATED);`
	`229`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%%count%%" parameter.', __METHOD__), E_USER_DEPRECATED);`
`230`	`230`
`231`	`231`	`if (!$this->formatter instanceof ChoiceMessageFormatterInterface) {`
`232`	`232`	`throw new LogicException(sprintf('The formatter "%s" does not support plural translations.', \get_class($this->formatter)));`