Fix getSetMethodNormalizer to correctly ignore the attributes specified in IGNORED_ATTRIBUTES

Emmanuel BORGES · Emmanuel BORGES · commit 0d28a1d992aa · 2019-03-06T12:41:26.000+01:00
diff --git a/UPGRADE-4.2.md b/UPGRADE-4.2.md
@@ -179,11 +179,12 @@ FrameworkBundle
  * The `Templating\Helper\TranslatorHelper::transChoice()` method has been deprecated, use the `trans()` one instead with a `%count%` parameter.
  * Deprecated support for legacy translations directories `src/Resources/translations/` and `src/Resources/<BundleName>/translations/`, use `translations/` instead.
  * Support for the legacy directory structure in `translation:update` and `debug:translation` commands has been deprecated.
+ * The `GetSetMethodNormalizer` class correctly ignores the attributes specified in `AbstractNormalizer::IGNORED_ATTRIBUTES`.
 
 HttpFoundation
 --------------
 
- * The default value of the `$secure` and `$samesite` arguments of Cookie's constructor
+ * The default value of the `$secure` and `$samesite` arguments o`f Cookie's constructor
    will respectively change from `false` to `null` and from `null` to `lax` in Symfony
    5.0, you should define their values explicitly or use `Cookie::create()` instead.
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
@@ -110,7 +110,7 @@ protected function extractAttributes($object, $format = null, array $context = [
 
             $attributeName = lcfirst(substr($method->name, 0 === strpos($method->name, 'is') ? 2 : 3));
 
-            if ($this->isAllowedAttribute($object, $attributeName)) {
+            if ($this->isAllowedAttribute($object, $attributeName, null, $context)) {
                 $attributes[] = $attributeName;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ protected function extractAttributes($object, $format = null, array $context = [`
`110`	`110`
`111`	`111`	`$attributeName = lcfirst(substr($method->name, 0 === strpos($method->name, 'is') ? 2 : 3));`
`112`	`112`
`113`		`- if ($this->isAllowedAttribute($object, $attributeName)) {`
	`113`	`+ if ($this->isAllowedAttribute($object, $attributeName, null, $context)) {`
`114`	`114`	`$attributes[] = $attributeName;`
`115`	`115`	`}`
`116`	`116`	`}`