[Workflow] Add MermaidDumper support for marking

eFrane · eFrane · commit 0b830c0052a8 · 2021-03-07T17:51:09.000+01:00
diff --git a/src/Symfony/Component/Workflow/Dumper/MermaidDumper.php b/src/Symfony/Component/Workflow/Dumper/MermaidDumper.php
@@ -69,19 +69,24 @@ public function __construct(string $transitionType, string $direction = self::DI
     public function dump(Definition $definition, Marking $marking = null, array $options = []): string
     {
         $this->linkCount = 0;
+        $placeNameMap = [];
+        $placeId = 0;
 
         $output = ['graph '.$this->direction];
 
         $meta = $definition->getMetadataStore();
 
-        $placeNameMap = [];
-
-        $placeId = 0;
         foreach ($definition->getPlaces() as $place) {
+            $placeMeta = $meta->getPlaceMetadata($place);
+
+            if (null !== $marking && $marking->has($place)) {
+                $placeMeta['has_marking'] = true;
+            }
+
             [$placeNode, $placeStyle] = $this->preparePlace(
                 $placeId,
                 $place,
-                $meta->getPlaceMetadata($place),
+                $placeMeta,
                 \in_array($place, $definition->getInitialPlaces())
             );
 
@@ -172,16 +177,24 @@ private function preparePlace(int $placeId, string $placeName, array $meta, bool
 
     private function styleNode(array $meta, string $nodeName): string
     {
-        $nodeStyle = '';
+        $nodeStyles = [];
+
         if (\array_key_exists('bg_color', $meta)) {
-            $nodeStyle = sprintf(
-                'style %s fill:%s',
-                $nodeName,
+            $nodeStyles[] = sprintf(
+                'fill:%s',
                 $meta['bg_color']
             );
         }
 
-        return $nodeStyle;
+        if (\array_key_exists('has_marking', $meta)) {
+            $nodeStyles[] = 'stroke-width:4px';
+        }
+
+        if (0 === count($nodeStyles)) {
+            return '';
+        }
+
+        return sprintf('style %s %s', $nodeName, implode(',', $nodeStyles));
     }
 
     /**
diff --git a/src/Symfony/Component/Workflow/Tests/Dumper/MermaidDumperTest.php b/src/Symfony/Component/Workflow/Tests/Dumper/MermaidDumperTest.php
@@ -15,6 +15,7 @@
 use Symfony\Component\Workflow\Definition;
 use Symfony\Component\Workflow\DefinitionBuilder;
 use Symfony\Component\Workflow\Dumper\MermaidDumper;
+use Symfony\Component\Workflow\Marking;
 use Symfony\Component\Workflow\Tests\WorkflowBuilderTrait;
 use Symfony\Component\Workflow\Transition;
 
@@ -58,6 +59,18 @@ public function testDumpAsStatemachine(Definition $definition, string $expected)
         $this->assertEquals($expected, $dump);
     }
 
+    /**
+     * @dataProvider provideWorkflowWithMarking
+     */
+    public function testDumpWorkflowWithMarking(Definition $definition, Marking $marking, string $expected)
+    {
+        $dumper = new MermaidDumper(MermaidDumper::TRANSITION_TYPE_WORKFLOW);
+
+        $dump = $dumper->dump($definition, $marking);
+
+        $this->assertEquals($expected, $dump);
+    }
+
     public function provideWorkflowDefinitionWithoutMarking(): array
     {
         return [
@@ -182,4 +195,32 @@ public function provideStatemachine(): array
             ],
         ];
     }
+
+    public function provideWorkflowWithMarking(): array
+    {
+        $marking = new Marking();
+        $marking->mark('b');
+        $marking->mark('c');
+
+        return [
+            [
+                $this->createSimpleWorkflowDefinition(),
+                $marking,
+                "graph LR\n"
+                ."a0([\"a\"])\n"
+                ."b1[\"b\"]\n"
+                ."style b1 stroke-width:4px\n"
+                ."c2[\"c\"]\n"
+                ."style c2 fill:DeepSkyBlue,stroke-width:4px\n"
+                ."transition0((\"My custom transition label 2\"))\n"
+                ."a0-->transition0\n"
+                ."linkStyle 0 stroke:Grey\n"
+                ."transition0-->b1\n"
+                ."linkStyle 1 stroke:Grey\n"
+                ."transition1((\"t2\"))\n"
+                ."b1-->transition1\n"
+                ."transition1-->c2"
+            ],
+        ];
+    }
 }
