[Validator] Accept underscores in the URL validator as the URL will resolve correctly

battye · nicolas-grekas · commit 07cbe9473e34 · 2019-09-26T22:55:05.000+02:00
diff --git a/src/Symfony/Component/Validator/Constraints/UrlValidator.php b/src/Symfony/Component/Validator/Constraints/UrlValidator.php
@@ -25,7 +25,7 @@ class UrlValidator extends ConstraintValidator
             (%s)://                                 # protocol
             (([\.\pL\pN-]+:)?([\.\pL\pN-]+)@)?      # basic auth
             (
-                ([\pL\pN\pS\-\.])+(\.?([\pL\pN]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
+                ([\pL\pN\pS\-\_\.])+(\.?([\pL\pN]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
                     |                                                 # or
                 \d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}                    # an IP address
                     |                                                 # or
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
@@ -67,11 +67,14 @@ public function getValidUrls()
     {
         return [
             ['http://a.pl'],
+<<<<<<< HEAD
             ['http://www.example.com'],
             ['http://www.example.com.'],
             ['http://www.example.museum'],
             ['https://example.com/'],
             ['https://example.com:80/'],
+            ['http://examp_le.com'],
+            ['http://www.sub_domain.examp_le.com'],
             ['http://www.example.coop/'],
             ['http://www.test-example.com/'],
             ['http://www.symfony.com/'],
@@ -148,6 +151,7 @@ public function testInvalidUrls($url)
     public function getInvalidUrls()
     {
         return [
+<<<<<<< HEAD
             ['example.com'],
             ['://example.com'],
             ['http ://example.com'],
@@ -157,6 +161,16 @@ public function getInvalidUrls()
             ['http://example.com:aa'],
             ['ftp://example.fr'],
             ['faked://example.fr'],
+=======
+            ['google.com'],
+            ['://google.com'],
+            ['http ://google.com'],
+            ['http:/google.com'],
+            ['http://google.com::aa'],
+            ['http://google.com:aa'],
+            ['ftp://google.fr'],
+            ['faked://google.fr'],
+>>>>>>> [Validator] Accept underscores in the URL validator as the URL will resolve correctly
             ['http://127.0.0.1:aa/'],
             ['ftp://[::1]/'],
             ['http://[::1'],

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class UrlValidator extends ConstraintValidator`
`25`	`25`	`(%s):// # protocol`
`26`	`26`	`(([\.\pL\pN-]+:)?([\.\pL\pN-]+)@)? # basic auth`
`27`	`27`	`(`
`28`		`- ([\pL\pN\pS\-\.])+(\.?([\pL\pN]\|xn\-\-[\pL\pN-]+)+\.?) # a domain name`
	`28`	`+ ([\pL\pN\pS\-\_\.])+(\.?([\pL\pN]\|xn\-\-[\pL\pN-]+)+\.?) # a domain name`
`29`	`29`	`\| # or`
`30`	`30`	`\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3} # an IP address`
`31`	`31`	`\| # or`