bug #32899 [Mailer] fix wrong error message when connection closes unexpectedly (fabpot)

fabpot · fabpot · commit 0470ac33e83c · 2019-08-03T11:37:54.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [Mailer] fix wrong error message when connection closes unexpectedly | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | n/a | License | MIT | Doc PR | n/a When the initial connection to the SMTP is closed immediately by the server, the error is now more explicit. Commits ------- 887f27d [Mailer] fixed wrong error message when connection closes unexpectedly
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php
@@ -74,6 +74,9 @@ public function readLine(): string
             if ($metas['timed_out']) {
                 throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription()));
             }
+            if ($metas['eof']) {
+                throw new TransportException(sprintf('Connection to "%s" has been closed unexpectedly.', $this->getReadConnectionDescription()));
+            }
         }
 
         return $line;

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,9 @@ public function readLine(): string`
`74`	`74`	`if ($metas['timed_out']) {`
`75`	`75`	`throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription()));`
`76`	`76`	`}`
	`77`	`+ if ($metas['eof']) {`
	`78`	`+ throw new TransportException(sprintf('Connection to "%s" has been closed unexpectedly.', $this->getReadConnectionDescription()));`
	`79`	`+ }`
`77`	`80`	`}`
`78`	`81`
`79`	`82`	`return $line;`