Remove Process::escapeArgument argument type hint

vudaltsov · vudaltsov · commit 01f4f0b1439a · 2018-10-14T20:12:19.000+03:00
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -1530,14 +1530,15 @@ private function requireProcessIsTerminated(string $functionName)
     /**
      * Escapes a string to be used as a shell argument.
      */
-    private function escapeArgument(string $argument): string
+    private function escapeArgument($argument): string
     {
+        $argument = (string) $argument;
+        if ('' === $argument) {
+            return '""';
+        }
         if ('\\' !== \DIRECTORY_SEPARATOR) {
             return "'".str_replace("'", "'\\''", $argument)."'";
         }
-        if ('' === $argument = (string) $argument) {
-            return '""';
-        }
         if (false !== strpos($argument, "\0")) {
             $argument = str_replace("\0", '?', $argument);
         }
