Provide a value if possible when parameter is not found

MatTheCat · MatTheCat · commit 00df47929f18 · 2023-05-16T11:32:03.000+02:00
diff --git a/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php b/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
@@ -31,8 +31,12 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
 
         $name = $attribute->name ?? $argument->getName();
         if (!$request->query->has($name)) {
-            if ($argument->isNullable() || $argument->hasDefaultValue()) {
-                return [];
+            if ($argument->hasDefaultValue()) {
+                return [$argument->getDefaultValue()];
+            }
+
+            if ($argument->isNullable()) {
+                return [null];
             }
 
             throw new NotFoundHttpException(sprintf('Missing query parameter "%s".', $name));
diff --git a/src/Symfony/Component/HttpKernel/Tests/Controller/ArgumentResolver/QueryParameterValueResolverTest.php b/src/Symfony/Component/HttpKernel/Tests/Controller/ArgumentResolver/QueryParameterValueResolverTest.php
@@ -179,14 +179,14 @@ public static function provideTestResolve(): iterable
         yield 'parameter not found but nullable' => [
             Request::create('/', 'GET'),
             new ArgumentMetadata('firstName', 'string', false, false, false, true, [new MapQueryParameter()]),
-            [],
+            [null],
             null,
         ];
 
         yield 'parameter not found but optional' => [
             Request::create('/', 'GET'),
             new ArgumentMetadata('firstName', 'string', false, true, false, attributes: [new MapQueryParameter()]),
-            [],
+            [false],
             null,
         ];
 
