[WebServerBundle] Code review changes

jschaedl · jschaedl · commit 0022b33c7ba1 · 2019-04-28T14:11:04.000+02:00
- removed unnecessary argument
- added return type hint
diff --git a/src/Symfony/Bundle/WebServerBundle/DependencyInjection/WebServerExtension.php b/src/Symfony/Bundle/WebServerBundle/DependencyInjection/WebServerExtension.php
@@ -61,7 +61,7 @@ private function getPublicDirectory(ContainerBuilder $container)
         return $kernelProjectDir.'/'.$publicDir;
     }
 
-    private function getPidFileDirectory(ContainerBuilder $container)
+    private function getPidFileDirectory(ContainerBuilder $container): string
     {
         $kernelCacheDir = $container->getParameter('kernel.cache_dir');
         $environment = $container->getParameter('kernel.environment');
@@ -70,6 +70,6 @@ private function getPidFileDirectory(ContainerBuilder $container)
             return $container->getParameter('kernel.project_dir');
         }
 
-        return \dirname($container->getParameter('kernel.cache_dir'), 1);
+        return \dirname($container->getParameter('kernel.cache_dir'));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ private function getPublicDirectory(ContainerBuilder $container)`
`61`	`61`	`return $kernelProjectDir.'/'.$publicDir;`
`62`	`62`	`}`
`63`	`63`
`64`		`- private function getPidFileDirectory(ContainerBuilder $container)`
	`64`	`+ private function getPidFileDirectory(ContainerBuilder $container): string`
`65`	`65`	`{`
`66`	`66`	`$kernelCacheDir = $container->getParameter('kernel.cache_dir');`
`67`	`67`	`$environment = $container->getParameter('kernel.environment');`
`@@ -70,6 +70,6 @@ private function getPidFileDirectory(ContainerBuilder $container)`
`70`	`70`	`return $container->getParameter('kernel.project_dir');`
`71`	`71`	`}`
`72`	`72`
`73`		`- return \dirname($container->getParameter('kernel.cache_dir'), 1);`
	`73`	`+ return \dirname($container->getParameter('kernel.cache_dir'));`
`74`	`74`	`}`
`75`	`75`	`}`