Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.7
Choose a base ref
...
head repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.8
Choose a head ref
  • 20 commits
  • 28 files changed
  • 9 contributors

Commits on Oct 31, 2018

  1. Configuration menu
    Copy the full SHA
    3562829 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Configuration menu
    Copy the full SHA
    ba8e63d View commit details
    Browse the repository at this point in the history
  2. bug #29054 [VarDumper] fix dump of closures created from callables (n…

    …icolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [VarDumper] fix dump of closures created from callables
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    We are missing displaying full information about closures created using `ReflectionMethod::getClosure()` or `Closure::fromCallable()`.
    
    This PR fixes it. For VarDumper but also other places where we have logic to display them.
    
    Commits
    -------
    
    1c1818b876 [VarDumper] fix dump of closures created from callables
    nicolas-grekas committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    01cb93f View commit details
    Browse the repository at this point in the history
  3. Merge branch '3.4' into 4.1

    * 3.4:
      [VarDumper] fix dump of closures created from callables
      [DI] fix dumping inlined services
      Add framework asset changes to upgrade 3.0 guide
      [Travis] Bump ext-mongodb to 1.5.2 on Travis
      [DI] dont track classes/interfaces used to compute autowiring error messages
      [DI] fix GraphvizDumper ignoring inline definitions
      bumped Symfony version to 3.4.19
      updated VERSION for 3.4.18
      updated CHANGELOG for 3.4.18
      bumped Symfony version to 2.8.48
      updated VERSION for 2.8.47
      update CONTRIBUTORS for 2.8.47
      updated CHANGELOG for 2.8.47
      Fix ini_get() for boolean values
    nicolas-grekas committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    d057bd5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Configuration menu
    Copy the full SHA
    8888e40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60b7fcb View commit details
    Browse the repository at this point in the history
  3. Remove unused dependency

    gonzalovilaseca authored and nicolas-grekas committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    5c8a020 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2018

  1. Configuration menu
    Copy the full SHA
    010dad3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    473fbd1 View commit details
    Browse the repository at this point in the history
  3. Bump phpunit XSD version to 5.2

    Some attributes being used in the phpunit configuration files, namely
    failOnRisky and failOnWarning were introduced in phpunit 5.2.0. The
    Composer configuration shows that tests should run with old versions of
    phpunit, but phpunit only validates the configuration against the XSD
    since phpunit 7.2.0.
    These changes can be tested as follows:
    
    wget http://schema.phpunit.de/5.2/phpunit.xsd
    xargs xmllint --schema phpunit.xsd  1>/dev/null
    find src -name phpunit.xml.dist| xargs xmllint --schema phpunit.xsd  1>/dev/null
    
    See sebastianbergmann/phpunit@7e06a82
    See https://github.com/symfony/symfony/blob/46e3745a03e199e64cc0fcf3284a96b5a25dcee9/composer.json#L98
    greg0ire committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    d93ad84 View commit details
    Browse the repository at this point in the history
  4. Merge branch '2.8' into 3.4

    * 2.8:
      [Form] Hardened test suite for empty data
      Bump phpunit XSD version to 5.2
      Add required key attribute
    nicolas-grekas committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    1bc6dd0 View commit details
    Browse the repository at this point in the history
  5. Merge branch '3.4' into 4.1

    * 3.4:
      [Form] Hardened test suite for empty data
      Bump phpunit XSD version to 5.2
      [Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables
      Add required key attribute
    nicolas-grekas committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    d7eaae6 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. bug #28731 [Form] invalidate forms on transformation failures (xabbuh)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] invalidate forms on transformation failures
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #20916, #21242, #28584
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    385d9df29c invalidate forms on transformation failures
    fabpot committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    6a7bb97 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. bug #29137 [Workflow][FrameworkBundle] fixed guard event names for tr…

    …ansitions (destillat, lyrixx)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Workflow][FrameworkBundle] fixed guard event names for transitions
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28018 symfony/symfony#28007 (comment)
    | License       | MIT
    | Doc PR        |
    
    There is a bug when many transitions are defined with the same name.
    I finished destillat's work and rebase against 3.4 as it's a bug fix.
    
    There another point of failure, but it could not be fixed on 3.4. I will
    be a need feature. The issue is related to `Workflow::can($subject, $transitionName)`.
    Since the transitionName could be not unique, we will need to support
    passing an instance of Transition. A new PR is incomming
    
    Commits
    -------
    
    83dc473dd6 [FrameworkBundle] fixed guard event names for transitions
    fb88bfc79a [FrameworkBundle] fixed guard event names for transitions
    lyrixx committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    0647c5a View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.1

    * 3.4:
      Update symfony links to https
      [FrameworkBundle] fixed guard event names for transitions
      [FrameworkBundle] fixed guard event names for transitions
    lyrixx committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    2d0c3a6 View commit details
    Browse the repository at this point in the history
  3. Merge branch '2.8' into 3.4

    * 2.8:
      [Form] Fixed keeping hash of equal \DateTimeInterface on submit
      [PhpUnitBridge] Fix typo
      [Config] Unset key during normalization
      invalidate forms on transformation failures
    nicolas-grekas committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    7ba6e60 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Merge branch '3.4' into 4.1

    * 3.4:
      Command::addOption should allow int in $default
      [Form] Fixed keeping hash of equal \DateTimeInterface on submit
      [PhpUnitBridge] Fix typo
      [Form] Minor fixes in docs and cs
      [Config] Unset key during normalization
      [Form] Fixed empty data for compound date types
      invalidate forms on transformation failures
      [PropertyAccessor] Fix unable to write to singular property using setter while plural adder/remover exist
    nicolas-grekas committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    3d18f0a View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Configuration menu
    Copy the full SHA
    05cf650 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. bug #28769 [FrameworkBundle] deal with explicitly enabled workflow no…

    …des (xabbuh)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] deal with explicitly enabled workflow nodes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | not yet
    | Fixed tickets | #28662
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    017fd56bd8 deal with explicitly enabled workflow nodes
    lyrixx committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    1c1f86b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Merge branch '3.4' into 4.1

    * 3.4:
      fix cs
      SCA: consolidate non empty array checks across codebase
      [cs] correct invalid @param types
      [Bridge/PhpUnit] Use composer to download phpunit
      [DI] fix taking lazy services into account when dumping the container
      [Form] Fixed empty data for compound date interval
      [Cache] fix optimizing Psr6Cache for AdapterInterface pools
      deal with explicitly enabled workflow nodes
    nicolas-grekas committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    a42d1ab View commit details
    Browse the repository at this point in the history
Loading