Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/dependency-injection
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.7
Choose a base ref
...
head repository: symfony/dependency-injection
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.8
Choose a head ref
  • 16 commits
  • 39 files changed
  • 2 contributors

Commits on Nov 6, 2018

  1. Configuration menu
    Copy the full SHA
    28c5017 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b4c29b View commit details
    Browse the repository at this point in the history
  3. bug #29102 [DI] fix GraphvizDumper ignoring inline definitions (nicol…

    …as-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] fix GraphvizDumper ignoring inline definitions
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Since SF3, inline definitions are first class citizen. I noticed that the GraphvizDumper does not inspect them. Here is the fix.
    
    Commits
    -------
    
    ebe6265504 [DI] fix GraphvizDumper ignoring inline definitions
    nicolas-grekas committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    ebec1fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb9ca55 View commit details
    Browse the repository at this point in the history
  5. bug #29104 [DI] fix dumping inlined services (nicolas-grekas)

    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] fix dumping inlined services
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28824 #29078
    | License       | MIT
    | Doc PR        | -
    
    Same as #29103 but for 3.4.
    
    This PR dump inline services using the call-stack to sort the code for instantiating them.
    This makes easier to follow and matches the behavior one would expect (and has when using `ContainerBuiler` directly to create services.)
    
    Commits
    -------
    
    a97606d58a [DI] fix dumping inlined services
    nicolas-grekas committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    9d2e5ef View commit details
    Browse the repository at this point in the history
  6. Merge branch '3.4' into 4.1

    * 3.4:
      [VarDumper] fix dump of closures created from callables
      [DI] fix dumping inlined services
      Add framework asset changes to upgrade 3.0 guide
      [Travis] Bump ext-mongodb to 1.5.2 on Travis
      [DI] dont track classes/interfaces used to compute autowiring error messages
      [DI] fix GraphvizDumper ignoring inline definitions
      bumped Symfony version to 3.4.19
      updated VERSION for 3.4.18
      updated CHANGELOG for 3.4.18
      bumped Symfony version to 2.8.48
      updated VERSION for 2.8.47
      update CONTRIBUTORS for 2.8.47
      updated CHANGELOG for 2.8.47
      Fix ini_get() for boolean values
    nicolas-grekas committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    e0bd358 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2018

  1. Configuration menu
    Copy the full SHA
    dbefbc2 View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.1

    * 3.4:
      [DI] align IniFileLoader to PHP bugfix #76965
    nicolas-grekas committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    9279614 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2018

  1. Bump phpunit XSD version to 5.2

    Some attributes being used in the phpunit configuration files, namely
    failOnRisky and failOnWarning were introduced in phpunit 5.2.0. The
    Composer configuration shows that tests should run with old versions of
    phpunit, but phpunit only validates the configuration against the XSD
    since phpunit 7.2.0.
    These changes can be tested as follows:
    
    wget http://schema.phpunit.de/5.2/phpunit.xsd
    xargs xmllint --schema phpunit.xsd  1>/dev/null
    find src -name phpunit.xml.dist| xargs xmllint --schema phpunit.xsd  1>/dev/null
    
    See sebastianbergmann/phpunit@7e06a82
    See https://github.com/symfony/symfony/blob/46e3745a03e199e64cc0fcf3284a96b5a25dcee9/composer.json#L98
    greg0ire committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    a2f40df View commit details
    Browse the repository at this point in the history
  2. Merge branch '2.8' into 3.4

    * 2.8:
      [Form] Hardened test suite for empty data
      Bump phpunit XSD version to 5.2
      Add required key attribute
    nicolas-grekas committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    831b9d9 View commit details
    Browse the repository at this point in the history
  3. Merge branch '3.4' into 4.1

    * 3.4:
      [Form] Hardened test suite for empty data
      Bump phpunit XSD version to 5.2
      [Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables
      Add required key attribute
    nicolas-grekas committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    3d4682d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Configuration menu
    Copy the full SHA
    0c1ba48 View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.1

    * 3.4:
      [DI] dont fail on missing classes when resource tracking is disabled
      [Validator] Added the missing constraints instance checks
    nicolas-grekas committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b845813 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Configuration menu
    Copy the full SHA
    5ec6098 View commit details
    Browse the repository at this point in the history
  2. fix cs

    nicolas-grekas committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    e1a4f85 View commit details
    Browse the repository at this point in the history
  3. Merge branch '3.4' into 4.1

    * 3.4:
      fix cs
      SCA: consolidate non empty array checks across codebase
      [cs] correct invalid @param types
      [Bridge/PhpUnit] Use composer to download phpunit
      [DI] fix taking lazy services into account when dumping the container
      [Form] Fixed empty data for compound date interval
      [Cache] fix optimizing Psr6Cache for AdapterInterface pools
      deal with explicitly enabled workflow nodes
    nicolas-grekas committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    9508a26 View commit details
    Browse the repository at this point in the history
Loading