[MCP SDK] Use foreach instead of array_map because array_map does not accept generators
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accept generators
dorrogeray
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
dorrogeray
force-pushed
the
fix-array-map-consuming-generators
branch
from
44750cc to
35c6c5b
Compare
welcoMattic
changed the title
array_map because array_map does not accept generators
OskarStark
changed the title
array_map because array_map does not accept generatorsarray_map because array_map does not accept generators
chr-hertel
reviewed
Jul 17, 2025
Comment on lines
+29
to
+33
| $collection = $this->getMockBuilder(CollectionInterface::class) | ||
| ->disableOriginalConstructor() | ||
| ->onlyMethods(['getMetadata']) | ||
| ->getMock(); | ||
| $collection->expects($this->once())->method('getMetadata')->willReturn([]); |
There was a problem hiding this comment.
For me it would be totally fine to go with a real instance instead:
Suggested change
| $collection = $this->getMockBuilder(CollectionInterface::class) | |
| ->disableOriginalConstructor() | |
| ->onlyMethods(['getMetadata']) | |
| ->getMock(); | |
| $collection->expects($this->once())->method('getMetadata')->willReturn([]); | |
| $collection = new PromptChain([]); |
chr-hertel
reviewed
Jul 17, 2025
Comment on lines
+48
to
+52
| $collection = $this->getMockBuilder(CollectionInterface::class) | ||
| ->disableOriginalConstructor() | ||
| ->onlyMethods(['getMetadata']) | ||
| ->getMock(); | ||
| $collection->expects($this->once())->method('getMetadata')->willReturn($metadataList); |
There was a problem hiding this comment.
Same here:
Suggested change
| $collection = $this->getMockBuilder(CollectionInterface::class) | |
| ->disableOriginalConstructor() | |
| ->onlyMethods(['getMetadata']) | |
| ->getMock(); | |
| $collection->expects($this->once())->method('getMetadata')->willReturn($metadataList); | |
| $collection = new PromptChain($metadataList); |
chr-hertel
reviewed
Jul 17, 2025
Comment on lines
+76
to
+80
| $collection = $this->getMockBuilder(CollectionInterface::class) | ||
| ->disableOriginalConstructor() | ||
| ->onlyMethods(['getMetadata']) | ||
| ->getMock(); | ||
| $collection->expects($this->once())->method('getMetadata')->willReturn([$item, $item]); |
There was a problem hiding this comment.
And here:
Suggested change
| $collection = $this->getMockBuilder(CollectionInterface::class) | |
| ->disableOriginalConstructor() | |
| ->onlyMethods(['getMetadata']) | |
| ->getMock(); | |
| $collection->expects($this->once())->method('getMetadata')->willReturn([$item, $item]); | |
| $collection = new PromptChain([$item, $item]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use foreach instead of array_map because array_map does not accept generators and add test coverage.