Skip to content

fix: better handle $inspect on array mutations #16389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

fix: better handle $inspect on array mutations #16389

merged 3 commits into from
Jul 16, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Jul 16, 2025

Fixes #16375, and now $inspect is called only once per array-mutating method.

I guess nobody will do something like

let arr = $state([1, 2, 3]);
arr.shift = () => { throw new Error() }; // will make $inspect deferred until a successful call of array mutating method
$inspect(arr);
// later
arr.shift();

or in another way make the methods throwable because it's shooting into one's own leg.

Also, Array.prototype.shift.call(arr) will still trigger $inspect on each step. But patching the Array prototype is too much?

About the test inspect-console-trace - the error stack was expected to have at HTMLButtonElement.<anonymous> (path) but now it isn't in the last 10 stack calls.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: 5273f70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16389

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this fix

@Rich-Harris Rich-Harris merged commit 6cf3a19 into main Jul 16, 2025
15 checks passed
@Rich-Harris Rich-Harris deleted the fix-16375 branch July 16, 2025 13:55
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a sparse array in runes mode
2 participants