fix: better handle $inspect on array mutations #16389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16375, and now $inspect is called only once per array-mutating method.
I guess nobody will do something like
or in another way make the methods throwable because it's shooting into one's own leg.
Also,
Array.prototype.shift.call(arr)
will still trigger $inspect on each step. But patching the Array prototype is too much?About the test
inspect-console-trace
- the error stack was expected to haveat HTMLButtonElement.<anonymous> (path)
but now it isn't in the last 10 stack calls.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint