Skip to content

fix: silence autofocus a11y warning inside <dialog> #16341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix: silence autofocus a11y warning inside <dialog> #16341

merged 1 commit into from
Jul 11, 2025

Conversation

navorite
Copy link
Contributor

@navorite navorite commented Jul 11, 2025 •
edited
Loading

closes #9225

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: c02e9a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16341

@Ocean-OS Ocean-OS mentioned this pull request Jul 11, 2025
Merged
6 tasks
@Ocean-OS Ocean-OS merged commit 96c1a10 into sveltejs:main Jul 11, 2025
10 checks passed
@Ocean-OS
Copy link
Member

thank you!

@github-actions github-actions bot mentioned this pull request Jul 11, 2025
Merged
@navorite navorite deleted the dialog-a11y branch July 11, 2025 18:31
Ocean-OS added a commit that referenced this pull request Jul 11, 2025
@Ocean-OS
apply changes from #16340 and #16341
7df34a3
Ocean-OS added a commit that referenced this pull request Jul 14, 2025
@Ocean-OS @Rich-Harris
chore: clean up a11y analysis code (#16345)
82f6481 
* chore: clean up a11y analysis code

* lint

* apply changes from #16340 and #16341

* `utils.js` -> `index.js`

* remove unused exports

* remove unused exports

* newlines are free :)

* consolidate loops

* put the exported function up top

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocean-OS Ocean-OS Ocean-OS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong a11y wargning on <dialog> with autofocus attribute
2 participants
@navorite @Ocean-OS