Skip to content

feat(valid-prop-names-in-kit-pages): support params page prop #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Jul 15, 2025

Add support for sveltejs/kit#13999

Copy link

changeset-bot bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: 414c291

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GauBen GauBen changed the title feat: support params page prop feat(valid-prop-names-in-kit-pages): support params page prop Jul 15, 2025
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauBen LGTM. But can you add test for it?

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@414c291

Published Instant Preview Packages:

View Commit

@GauBen
Copy link
Contributor Author

GauBen commented Jul 16, 2025

Done!

@baseballyama baseballyama merged commit 4e33ba4 into sveltejs:main Jul 16, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants