Feat(add): vite.addPlugin()
#633
Conversation
🦋 Changeset detectedLatest commit: 13c7c1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
What's the purpose behind this change? As far as I'm aware we are currently only using this in one place (devtools-json) and the current code is smaller and better readable and understandable in my opinion.
But maybe I'm missing what you are trying to achieve here.
|
Ignore my last comment, just found the issue. let me check then |
There was a problem hiding this comment.
Overall this looks good and I understand the changes now. As for the file location, maybe we could do something like /tooling/js/vite as we already have /tooling/js/kit as well. Not a huge fan of this, but I think it would be better understandable than what we have right now.
|
haha, perfect 👍 |
|
Kinda beautiful 🫠 
|
fix #632
I just created a
helper.ts& some tests, but it should probably move to another location ?Maybe
addInArrayOfObject&exportDefaultConfigcould go incommon?And
addPluginToViteConfigis maybe a bit higher level ? Or it could go to common as well ?I did the demo on
devtoolplugin, and the API looks nice! no ? @benmccann @manuel3108 let me know what do you think.