feat: add `math/base/special/kernel-log1pf` #5411

Neerajpathak07 · 2025-02-24T12:56:04Z

Progresses #649, Resolves #5412.

Description

What is the purpose of this pull request?

This pull request:

adds math/base/special/kernel-log1pf which is the single-precision version of math/base/special/kernel-log1p

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

stdlib-bot · 2025-02-24T12:58:02Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/kernel-log1pf	$\color{red}365/369$ $\color{green}+98.92\%$	$\color{red}9/11$ $\color{green}+81.82\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{red}365/369$ $\color{green}+98.92\%$

The above coverage report was generated for the changes in this PR.

Neerajpathak07 · 2025-02-24T13:11:04Z

Will be needing this to implement some big packages like log2f and log10f
Also there are little gaps in the code coverage for polyval_p.js and polyval_q.js was it because these functions were auto-generated or something that we should expect??
cc: @kgryte @Planeshifter @gunjjoshi

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/lib/polyval_p.js

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.js

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.native.js

gunjjoshi · 2025-02-24T20:23:05Z

@Neerajpathak07 You'll achieve 100% code coverage once you've added the above two tests.

kgryte · 2025-02-25T00:10:26Z

In general, it is possible that not allow Horner branches will be exercised. However, in this case, as @gunjjoshi pointed out, you can achieve full coverage by reasoning about the implementation code.

kgryte · 2025-02-25T00:11:13Z

@gunjjoshi Would you mind doing a review of this PR?

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed ---

Neerajpathak07 · 2025-02-25T04:07:44Z

/stdlib merge

Neerajpathak07 · 2025-02-25T04:14:34Z

@gunjjoshi Thanks for the assist I believe we have achieved 100% code coverage.

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/benchmark/c/native/benchmark.c

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/benchmark/benchmark.js

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/src/main.c

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.js

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.native.js

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.js

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.native.js

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Neerajpathak07 · 2025-02-25T13:58:20Z

@gunjjoshi lmk if there are still some changes to be made.

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/lib/main.js

…ain.js Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Neerajpathak07 · 2025-02-25T17:04:36Z

@gunjjoshi Thank you for the reviews!!

Neerajpathak07 · 2025-02-25T18:06:40Z

@kgryte Could we land this in?

Neerajpathak07 · 2025-03-21T04:40:50Z

@kgryte Could we land this in will be needing it to implement a few other packages?

anandkaranubc · 2025-07-14T04:33:06Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte

LGTM

feat: add kernel-log1pf

1311019

Neerajpathak07 marked this pull request as draft February 24, 2025 12:56

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 24, 2025

chore: update markdown

a8120aa

Neerajpathak07 marked this pull request as ready for review February 24, 2025 13:11

gunjjoshi reviewed Feb 24, 2025

View reviewed changes

kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 25, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 25, 2025

Merge remote-tracking branch 'upstream/develop' into add-kernel-log1pf

0e6f1ad

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 25, 2025

gunjjoshi requested changes Feb 25, 2025

View reviewed changes

gunjjoshi and others added 2 commits February 25, 2025 10:46

Apply suggestions from code review

4f8b523

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

chore: stuff from code review

de931cd

Neerajpathak07 commented Feb 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.js Outdated Show resolved Hide resolved

chore: rearrange modules

3e9459b

gunjjoshi reviewed Feb 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/test/test.native.js Outdated Show resolved Hide resolved

gunjjoshi and others added 2 commits February 25, 2025 14:22

Apply suggestions from code review

c56c30e

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

chore: update benchmark

2f2a721

gunjjoshi reviewed Feb 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/kernel-log1pf/lib/main.js Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/math/base/special/kernel-log1pf/lib/m…

ada5880

…ain.js Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

gunjjoshi previously approved these changes Feb 25, 2025

View reviewed changes

gunjjoshi requested a review from kgryte March 2, 2025 07:12

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 2, 2025

gunjjoshi removed the Needs Changes Pull request which needs changes before being merged. label Mar 2, 2025

Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025

kgryte removed the Potential Duplicate There might be another pull request resolving the same issue. label Mar 21, 2025

kgryte requested a review from anandkaranubc July 4, 2025 09:31

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 14, 2025

Merge remote-tracking branch 'upstream/develop' into add-kernel-log1pf

fe5ece6

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 14, 2025

anandkaranubc dismissed gunjjoshi’s stale review via d16677b July 14, 2025 05:02

anandkaranubc added 7 commits July 14, 2025 10:35

anandkaranubc mentioned this pull request Jul 14, 2025

Weekly Standup (2025-07-14) stdlib-js/google-summer-of-code#162

Open

anandkaranubc approved these changes Jul 14, 2025

View reviewed changes

kgryte approved these changes Jul 16, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Jul 16, 2025

kgryte merged commit 4b11de2 into stdlib-js:develop Jul 16, 2025
12 checks passed

Uh oh!

feat: add math/base/special/kernel-log1pf #5411

feat: add math/base/special/kernel-log1pf #5411

Uh oh!

Conversation

Neerajpathak07 commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Neerajpathak07 commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gunjjoshi commented Feb 24, 2025

Uh oh!

kgryte commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kgryte commented Feb 25, 2025

Uh oh!

Neerajpathak07 commented Feb 25, 2025

Uh oh!

Neerajpathak07 commented Feb 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Neerajpathak07 commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Neerajpathak07 commented Feb 25, 2025

Uh oh!

Neerajpathak07 commented Feb 25, 2025

Uh oh!

Neerajpathak07 commented Mar 21, 2025

Uh oh!

anandkaranubc commented Jul 14, 2025

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: add `math/base/special/kernel-log1pf` #5411

feat: add `math/base/special/kernel-log1pf` #5411

Neerajpathak07 commented Feb 24, 2025 •

edited

Loading

stdlib-bot commented Feb 24, 2025 •

edited

Loading

Neerajpathak07 commented Feb 24, 2025 •

edited

Loading

kgryte commented Feb 25, 2025 •

edited

Loading

Neerajpathak07 commented Feb 25, 2025 •

edited

Loading