Skip to content

Add .vscode config files to better integrate with Azure Static Web Apps extension #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2021

Conversation

alexweininger
Copy link
Contributor

@alexweininger alexweininger commented Jul 28, 2021

👋

My name is Alex and I'm working on adding better support for templates in the Azure Static Web Apps VS Code extension.

This PR has two additions:

  1. Adding staticWebApps.outputSubpath setting with a value of dist/angular-basic in .vscode/settings.json

This addition makes it so that users can accept the default configurations when deploying this template via the Azure Static Web Apps VS Code extension. Adding the setting allows us to prefill the prompt with the correct configuration for this template. Before now, if the user selected the defaults then the template would fail to build once pushed/deployed to GitHub/Azure. Which is a really terrible 😢 experience for new users that we'd love to prevent.

Screenshot:
image

See related issues if you want more context:

  1. Adding ms-azuretools.vscode-azurestaticwebapps to recommended extensions in .vscode/extensions.json

More details about what we are planning for the "Create from template" feature in our extension:

@anthonychu
Copy link
Contributor

@craigshoemaker could you please take a look?

@staticwebdev staticwebdev merged commit f9cd80a into staticwebdev:main Jul 31, 2021
@craigshoemaker
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants