Skip to content

Improve email sending error handling #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 16, 2025
Merged

Improve email sending error handling #732

merged 15 commits into from
Jul 16, 2025

Conversation

fomalhautb
Copy link
Contributor

@fomalhautb fomalhautb commented Jun 27, 2025

Important

Improves email sending error handling in emails.tsx by introducing StatusError and a centralized error handling function for consistent and user-friendly error reporting.

  • Error Handling:
    • Introduced StatusError for better error reporting in emails.tsx.
    • Added handleError function in sendEmail() to log errors and throw StatusError with a user-friendly message.
  • Email Sending Logic:
    • Updated sendEmail() to use handleError for consistent error handling.
    • Ensures retries for transient errors and logs specific errors for shared email configurations.
  • Misc:
    • Minor refactoring in sendEmail() to improve code clarity and maintainability.

This description was created by Ellipsis for b6dad5d. You can customize this summary. It will automatically update as commits are pushed.

- Introduced `StatusError` for improved error reporting when email sending fails.
- Added a centralized error handling function to log errors and provide user-friendly messages.
- Updated the email sending logic to utilize the new error handling, ensuring consistent feedback for failed email attempts.

This change improves the robustness of the email sending process and enhances the developer experience by providing clearer error messages.
Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 0:11am
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 0:11am
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 0:11am
stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 0:11am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced email sending error handling by implementing StatusError with centralized error reporting and user-friendly messages in apps/backend/src/lib/emails.tsx.

  • Added centralized handleError function for consistent error reporting and logging
  • Implemented retry logic with improved error state tracking
  • Added specific error types from known-errors.tsx for email-related failures
  • Used StatusError for HTTP-appropriate error responses when email sending fails

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link

recurseml bot commented Jun 27, 2025

✨ No issues found! Your code is sparkling clean! ✨

🗒️ View all ignored comments in this repo
  • The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
  • Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
  • There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
  • Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

  • Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
  • The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

  • Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
  • The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

  • 'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

  • When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

Need help? Join our Discord for support!
https://discord.gg/NCpkJ4kF

@N2D4 N2D4 assigned fomalhautb and unassigned N2D4 Jul 2, 2025
@fomalhautb fomalhautb assigned N2D4 and unassigned fomalhautb Jul 9, 2025
@N2D4 N2D4 assigned fomalhautb and unassigned N2D4 Jul 9, 2025
@fomalhautb fomalhautb merged commit c7d2601 into dev Jul 16, 2025
15 of 17 checks passed
@fomalhautb fomalhautb deleted the handle-email-error branch July 16, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants