Skip to content

add ; to CREATE TABLE statement for Copy Create statement #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yfdyh000
Copy link
Contributor

Before this, if you copied and pasted the Database Structure - Table items multiple times and tried to execute SQL statements, you would get syntax errors due to missing ;.

@justinclift
Copy link
Member

Hi, it looks like you're generating quite a few PRs in a short space of time.

Thanks for your enthusiasm. 😄

Just to check something, are you using AI of some variety to help with generating these PRs?

If so, please don't use AI generated code in the PRs. It's probably fine to use AI to help locate potential bugs then investigate yourself, but AI generated code is not well understood from a licensing perspective.

Different countries around the world have different ideas and it'll probably be a few more years until a clearer understanding of legalities emerges. 😄

@yfdyh000
Copy link
Contributor Author

Hello, thank you for your comment. I manually handle the tracking, committing and testing of these PRs. AI Tools like GitHub Copilot are used occasionally for trivial queries and guidance, as well as for auto-completion within VS. If you think anything might be copyrighted, please let me know. Otherwise, I think they are just simple logical snippets and not a cause for concern. 😊

By the way, I still keep track of over 50 issues for this project (accumulated over time and out of passion), but organizing, fixing, proposing or discussing them remains a challenging task. I'm not sure of the best practices, as the project is not very active.

@justinclift
Copy link
Member

I think they are just simple logical snippets and not a cause for concern.

No worries, was just checking to be careful. 😄

@mgrojo
Copy link
Member

mgrojo commented May 24, 2025

I'm not sure about this simple change, because we might break some table creation statement, while the ';' is easy to add by the user. Can we be sure it is always safe to add the semicolon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants