Skip to content

[PostgreSQL]Update: Complete Implementation of RESET generation in Postgres #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[PostgreSQL]Update: Complete Implementation of RESET generation in Postgres #1202

wants to merge 10 commits into from

Conversation

codebreaker32
Copy link

I have completed the RESET usage in PostgresProvider.java by

  • Creating a dedicated class for RESET generation i.e PostgresResetGenerator.java
  • I implemented this class by mimicking PostgresSetGenerator.java

Previously, It only supported RESET ALL for all queries.

@mrigger

@codebreaker32
Copy link
Author

Please review @mrigger

mrigger
mrigger reviewed Apr 8, 2025
View reviewed changes
@codebreaker32 codebreaker32 requested a review from mrigger April 9, 2025 06:33
mrigger
mrigger reviewed Apr 13, 2025
View reviewed changes
mrigger
mrigger reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks almost ready to be merged.

@codebreaker32 codebreaker32 requested a review from mrigger April 13, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrigger mrigger Awaiting requested review from mrigger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebreaker32 @mrigger