Refactor library. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete toolkit files. Migrate registers file to header. Refactor of library in progress.
Still need to finish commenting.
Update constructor defaults. Add getter for device Address. Add getters for outputs. Edit comments for brevity. Make fsr variables const instead of static constexpr. Consolidate begin functions. Add nullptr checks. Incorporate new readRegisterRegion functions. Rework prepareMeasurement. Add comments.
Add dependency.
gigapod
approved these changes
Dec 14, 2023
Update Examples to say halting rather than spinning. Add comments about why break time is set. Move driver to it's own underlying file. Make getDeviceID change op mode if needed. Add checking to setDeviceAddress. Make runDefaultSetup change op mode if needed. Move bulk of runDefaultSetup into the else statement so we don't do unnecessary things. prepareMeasurement now uses references and consts. Add comment to reset about OSR register availability. Add human readable versions of getters for gain, cclk, convTime. Rename original versions of those to Raw. Remove unnecessary if's in readRawUV. setDigitalDividerRange now defaults enabling the divider to true. Modify Arduino begin to take in a wire port. Remove unnecessary reset call in begin due to logic changes above.
sfe-SparkFro
requested changes
Dec 15, 2023
Make default case for setDeviceAddress do nothing. Manually setOSR in getDeviceID.
|
A lot of comments/commits - if you need me to look at anything just let me know... |
|
I think we're all set now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full refactor of the library.
Works with SparkFun Toolkit.
Reduced complexity.
Added comments.