Revert breaking change of minimum required ruby version introduced due to the latest io-event gem #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to the latest io-event gem
jjatinggoyal
force-pushed
the
revert-breaking-change
branch
from
6ad2a57 to
10a052b
Compare
|
A better option would be for you to move to the latest 3.2.x release, as there are some issues with earlier releases. However, I'm willing to entertain this request. |
|
@ioquatix I agree we should just use the latest 3.2.x, but I can't upgrade Ruby in our app without getting a bunch of approvals (I work at a corporate). So I'd be grateful if this PR can be merged for the benefit of apps on < 3.2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
async2.25.0 in a Rails app running on Ruby 3.2.2. I tried to upgrade to async 2.26.0, but theio-asyncgem's latest version (commit) has introduced a breaking change on the minimum required Ruby version (now requires Ruby >=3.2.6 instead of >=3.2).This commit reverts the minimum required version of
io-asyncgem inasyncto~> 1.11to maintainasyncgem's compatibility with Ruby >=3.2Type of Change
Contribution