-
-
Notifications
You must be signed in to change notification settings - Fork 23
minimally process standard lambda (dict) responses #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i am looking into it, i am using the opportunity to overhaul the travis versions test setup as well. stay tuned |
The travis tests are failing because of some linting plus python3.5 not being able to sort dicts during json dumping (i think) i have fixed both issues in a local copy of your branch. I will push them tomorrow when i get time. If you dont mind, i'd really like to hear more about how you stumbled upon lambdarest and what you generally use it for and in what scale (just for curiosity) |
I found this library because I'm a huge fan of the AWS CDK and I wanted a lightweight library that could help with routing without all of the deploy/infra baggage that comes with Chalice/Zappa/etc. I was going to roll my own as my first Google results weren't promising. I finally dug this repo up in Google with the right incantation after a few tries 😅. I'm using it for pet projects at the moment, but, ultimately I'm vetting it for my day job—we build everything in python on AWS. |
3ef023c
to
73d39e9
Compare
@adamelmore but i've removed the explicit assertion (in the test) that keys are indeed ordered after json encoding as its not part of the JSON rfc:
else i have revamped the setup/test instructions and switched back to using tox + pyenv for easy local testing against all major supported python versions btw. i have bumped the version to v8.0.0 as this seems like a breaking change as well as the last one edit: i am gonna merge this now |
5de5fbd
to
a7d6b53
Compare
…in travis, add badge to README
a7d6b53
to
34ad7bd
Compare
@adamelmore its released under v8.0.0 and tested installed:
|
Personally, I'd prefer to be able to return a normal lambda response from my handlers and not have to introduce a library-specific output format:
This allows the library to be used solely for its routing capabilities which is desirable to those that aren't interested in any output massaging.