don't json.dumps the body if it's already a str #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamelmore great find!! I'll take a look soon and see if we can get it out asap. Thx for your contribution! Everything matters! 😉 |
sloev
pushed a commit
that referenced
this pull request
Feb 12, 2020
|
@adamelmore i have released your changes with v. 7.0.0 as it is a breaking change |
|
Just FWIW, I was really happy to see that this library exists! I'm enjoying the AWS CDK and really wanted a lightweight routing library that plays nicely with it; Chalice/Zappa/etc. have too much infra/deploy baggage to be easily integrated with the CDK. Cheers! |
|
Yeah i aldo thought zappa etc had too much going on, which is why i created
this. And thanks to your words and the numerous contributions this package
have had i think it actually is useful for people.
Have a great sunny day!
ons. 12. feb. 2020 20.51 skrev Adam Elmore <notifications@github.com>:
… Just FWIW, I was really happy to see that this library exists! I'm
enjoying the AWS CDK and really wanted a lightweight routing library that
plays nicely with it; Chalice/Zappa/etc. have too much infra/deploy baggage
to be easily integrated with the CDK. Cheers!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#58>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGVGUJ73RUKSH3RR7BEGVLRCRHMRANCNFSM4KT6C2FA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody:
Me: "Hey, I'd like to contribute! Maybe I'll just change every test?" 😅
It's very possible I'm not understanding something, but in my experience, there's no need for
bodyto be encased in double-quotes; anxious to hear your thoughts! The double-quotes certainly break browser rendering of returned HTML output.