fixing Issue 824 #825
Draft
fixing Issue 824 #825
+231
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #824 related to handling of trailing ignorable characters in base64 decoding, specifically addressing how the input read count is reported according to TC39 base64 proposal specifications.
Key changes made:
- Modified the handling of trailing ignorable characters to include them in the reported read count instead of ignoring them
- Updated the behavior for empty input (containing only ignorable characters) to return the full input length instead of zero
- Enhanced partial chunk handling with stop_before_partial option to properly position after the last complete chunk
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/base64_tests.cpp | Adds new test cases for issue #824 and updates existing WebKit test cases to verify correct read/write counts |
| src/scalar/base64.h | Updates find_end function to include trailing spaces in full input length and modifies empty input handling |
| src/lsx/lsx_base64.cpp | Changes empty input case to return full_input_length instead of 0 |
| src/lasx/lasx_base64.cpp | Changes empty input case to return full_input_length instead of 0 |
| src/icelake/icelake_base64.inl.cpp | Changes empty input case and adds logic to skip ignored characters for stop_before_partial |
| src/generic/base64.h | Changes empty input case to return full_input_length instead of 0 |
| src/arm64/arm_base64.cpp | Changes empty input case to return full_input_length instead of 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #824
Thanks for the report by @syg
This PR changes the following things...
AAAA, we would declare having read 4 characters.I have added some tests.