update layout sider trigger height #3347

teboho · 2025-06-04T18:58:10Z

Before

After

Summary by CodeRabbit

Style
- Adjusted the height of the sider trigger element for improved layout consistency.
- Updated the header height for a more balanced layout appearance.

coderabbitai · 2025-06-04T18:58:16Z

Walkthrough

The layoutHeaderHeight value in the styles index was changed from "55px" to "51.5px". Correspondingly, a new CSS rule was added inside the mainSider style block targeting .ant-layout-sider-trigger to set its height using this updated value. No other changes were made.

Changes

File(s)	Change Summary
.../styles/index.ts	Modified `layoutHeaderHeight` value from `"55px"` to `"51.5px"`
.../mainLayout/styles/styles.ts	Added `.ant-layout-sider-trigger` rule with `height` set to `layoutTriggerHeight` (51.5px)

Suggested reviewers

James-Baloyi

Poem

A hop in the code, a tweak in the night,
The sider’s new height now fits just right.
With 51.5, the trigger stands tall,
A subtle adjustment, improving it all.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a47ef42 and e568665.

📒 Files selected for processing (2)

shesha-reactjs/src/components/mainLayout/styles/styles.ts (1 hunks)
shesha-reactjs/src/styles/index.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

shesha-reactjs/src/styles/index.ts

🚧 Files skipped from review as they are similar to previous changes (1)

shesha-reactjs/src/components/mainLayout/styles/styles.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build-attempt

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

shesha-reactjs/src/components/mainLayout/styles/styles.ts (1)
190-192: Extract hardcoded trigger height to a theme variable.
Hardcoding 51.5px directly makes future tweaks error-prone. Define a constant (e.g. const shaSiderTriggerHeight = '51.5px'; // @sha-sider-trigger-height) alongside your other size tokens, then reference it here for consistency and easier maintenance.
-    .ant-layout-sider-trigger {
-      height: 51.5px;
-    }
+    .ant-layout-sider-trigger {
+      height: ${shaSiderTriggerHeight};
+    }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a919b53 and 7a7c918.

📒 Files selected for processing (1)

shesha-reactjs/src/components/mainLayout/styles/styles.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build-attempt

shesha-reactjs/src/components/mainLayout/styles/styles.ts

IvanIlyichev

Hi @teboho.

You changes don't fix the issue, see the image below. Play with absolute sizes is a wrong way, content of the header should fit the size automatically using relative sizes and positions, flexes etc.
Please use ${prefixCls} instead of hardcoded .ant prefix
Please disable any code autoformatter like prettier. You changed just few lines of code but GitHub shows 523 changed lines. It makes code review more complex and may lead to bugs. Later I'll configure autoformatter with strict rules for entire project to prevent this issue

teboho added 2 commits June 4, 2025 20:53

update layout sider trigger height

7a7c918

file format ts

a47ef42

coderabbitai bot reviewed Jun 4, 2025

View reviewed changes

shesha-reactjs/src/components/mainLayout/styles/styles.ts Outdated Show resolved Hide resolved

teboho requested a review from IvanIlyichev June 4, 2025 19:02

use the common variable

e568665

IvanIlyichev requested changes Jun 5, 2025

View reviewed changes

teboho marked this pull request as draft June 12, 2025 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update layout sider trigger height #3347

update layout sider trigger height #3347

Uh oh!

teboho commented Jun 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 4, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

IvanIlyichev left a comment •

edited

Loading

Uh oh!

Uh oh!

update layout sider trigger height #3347

Are you sure you want to change the base?

update layout sider trigger height #3347

Uh oh!

Conversation

teboho commented Jun 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

IvanIlyichev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

teboho commented Jun 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

IvanIlyichev left a comment •

edited

Loading