Skip to content

feat: yml支持job镜像配置&修复cfs找不到挂载点问题 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wangpand0508
Copy link
Contributor

No description provided.

@wangpand0508 wangpand0508 force-pushed the feat/yml-support-job-image-and-internal-ip branch from 4bb601e to 7e5ecba Compare November 9, 2023 09:56
@@ -41,6 +42,8 @@ export const formatInputs = (inputs: ScfCreateFunctionInputs) => {
ImageConfig: {
ImageType: imageConfig.imageType,
ImageUri: imageConfig.imageUri,
ContainerImageAccelerate: imageConfig.containerImageAccelerate || false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开了加速的函数,可能更新的时候没传这个值,是不是就会走默认为false的逻辑?
考虑下判断是否传了这个参数,传了才设置

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已修改

@wangpand0508 wangpand0508 force-pushed the feat/yml-support-job-image-and-internal-ip branch from a51ea4f to 941de58 Compare November 9, 2023 11:22
@Serverlesstencent Serverlesstencent merged commit 0bff41b into serverless-tencent:master Nov 9, 2023
wangpand0508 added a commit to wangpand0508/tencent-component-toolkit that referenced this pull request Nov 15, 2023
Serverlesstencent pushed a commit that referenced this pull request Apr 24, 2024
# [2.25.0](v2.24.2...v2.25.0) (2024-04-24)

### Features

* yml支持job镜像配置&修复cfs找不到挂载点问题 ([#296](#296)) ([0bff41b](0bff41b))
* 部署函数支持添加云梯默认标签(运营部门,运营产品,负责人) ([#298](#298)) ([fa1d037](fa1d037))

### Reverts

* Revert "feat: yml支持job镜像配置&修复cfs找不到挂载点问题 (#296)" (#297) ([6034e25](6034e25)), closes [#296](#296) [#297](#297)
@Serverlesstencent
Copy link
Contributor

🎉 This PR is included in version 2.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants