Skip to content

Commit c62da6a

Browse files
sebssebs
committed
Add tsconfig.json and implement suggestions
1 parent 6cdb1ec commit c62da6a

File tree

8 files changed

+84
-16
lines changed

8 files changed

+84
-16
lines changed

‎src/entities/Address.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ import { EntityBase } from './EntityBase'
44

55
// a ethereum address
66
export class Address extends EntityBase implements IEntity {
7-
public errorMessage: string = 'invalid'
8-
private address
7+
private address: string
98
private regex = /0x[a-fA-F0-9]{40}/
109

1110
constructor(address: string) {
1211
super()
12+
this.errorMessage = 'Invalid Address'
1313
this.address = address
1414
}
1515

16-
public valid(): boolean {
16+
valid(): boolean {
1717
return this.address.match(this.regex) !== null
1818
}
1919
}

‎src/entities/Apikey.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ import { EntityBase } from './EntityBase'
44

55
// api key for etherscan.io
66
export class ApiKey extends EntityBase implements IEntity {
7-
public errorMessage: string = 'invalid'
8-
private apiKey
7+
errorMessage: string = 'invalid'
8+
private apiKey: string
99
private keyLength: number = 33
1010
constructor(apiKey: string) {
1111
super()
1212
this.apiKey = apiKey
1313
}
1414

15-
public valid(): boolean {
15+
valid(): boolean {
1616
return this.apiKey.length !== this.keyLength
1717
}
1818
}

‎src/entities/EntityBase.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,18 @@
22
// base class for entities
33
export abstract class EntityBase {
44
// basic error message for exceptions on validations
5-
public errorMessage: string
5+
errorMessage: string
66
// checks valid() and throws errorMessage
7-
public validate(): void {
7+
constructor() {
8+
this.errorMessage = 'invalid value'
9+
}
10+
validate(): void {
811
if (!this.valid()) {
912
throw new Error(this.errorMessage)
1013
}
1114
}
1215

13-
public valid(): boolean {
16+
valid(): boolean {
1417
return true
1518
}
1619
}

‎src/entities/HexQuantity.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ import { EntityBase } from './EntityBase'
55
* @see https://stackoverflow.com/questions/57803/how-to-convert-decimal-to-hexadecimal-in-javascript
66
*/
77
export class HexQuantity extends EntityBase implements IEntity {
8-
public errorMessage: string = 'invalid'
8+
errorMessage: string = 'invalid'
99
private hexString: string
1010

1111
constructor(hexString: string) {
1212
super()
1313
this.hexString = hexString
1414
}
1515

16-
public valid(): boolean {
16+
valid(): boolean {
1717
const a = parseInt(this.hexString, 16)
1818
return (a.toString(16) === this.hexString)
1919
}

‎src/entities/PositiveNumber.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,16 @@ import { EntityBase } from './EntityBase'
44

55
// a positive number
66
export class PositiveNumber extends EntityBase implements IEntity {
7-
public errorMessage: string = 'invalid'
7+
errorMessage: string
88
private positiveNumber: any
99

1010
constructor(positiveNumber: any) {
1111
super()
12+
this.errorMessage = 'invalid number'
1213
this.positiveNumber = positiveNumber
1314
}
1415

15-
public valid(): boolean {
16+
valid(): boolean {
1617

1718
const numerical = parseInt(this.positiveNumber, 3)
1819

‎src/entities/Sort.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ import { EntityBase } from './EntityBase'
55

66
// Sort Parameter asc or desc
77
export class Sort extends EntityBase implements IEntity {
8-
public errorMessage: string = 'invalid'
8+
errorMessage: string = 'invalid'
99
private sortParam: string
1010

1111
constructor(sortParam: string) {
1212
super()
1313
this.sortParam = sortParam
1414
}
1515

16-
public valid(): boolean {
16+
valid(): boolean {
1717
return sort.asc === this.sortParam || sort.desc === this.sortParam
1818
}
1919
}

‎tsconfig.json

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
{
2+
"compilerOptions": {
3+
/* Basic Options */
4+
// "incremental": true, /* Enable incremental compilation */
5+
"target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
6+
"module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
7+
// "lib": [], /* Specify library files to be included in the compilation. */
8+
// "allowJs": true, /* Allow javascript files to be compiled. */
9+
// "checkJs": true, /* Report errors in .js files. */
10+
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
11+
// "declaration": true, /* Generates corresponding '.d.ts' file. */
12+
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
13+
// "sourceMap": true, /* Generates corresponding '.map' file. */
14+
// "outFile": "./", /* Concatenate and emit output to single file. */
15+
// "outDir": "./", /* Redirect output structure to the directory. */
16+
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
17+
// "composite": true, /* Enable project compilation */
18+
// "tsBuildInfoFile": "./", /* Specify file to store incremental compilation information */
19+
// "removeComments": true, /* Do not emit comments to output. */
20+
// "noEmit": true, /* Do not emit outputs. */
21+
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
22+
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
23+
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
24+
25+
/* Strict Type-Checking Options */
26+
"strict": true, /* Enable all strict type-checking options. */
27+
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
28+
// "strictNullChecks": true, /* Enable strict null checks. */
29+
// "strictFunctionTypes": true, /* Enable strict checking of function types. */
30+
// "strictBindCallApply": true, /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
31+
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */
32+
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
33+
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
34+
35+
/* Additional Checks */
36+
// "noUnusedLocals": true, /* Report errors on unused locals. */
37+
// "noUnusedParameters": true, /* Report errors on unused parameters. */
38+
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
39+
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
40+
41+
/* Module Resolution Options */
42+
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
43+
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
44+
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
45+
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
46+
// "typeRoots": [], /* List of folders to include type definitions from. */
47+
// "types": [], /* Type declaration files to be included in compilation. */
48+
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
49+
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
50+
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */
51+
// "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */
52+
53+
/* Source Map Options */
54+
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
55+
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
56+
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
57+
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
58+
59+
/* Experimental Options */
60+
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */
61+
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
62+
}
63+
}

‎tslint.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
"rules": {
88
"semicolon": [true, "never"],
99
"indent": [true, "spaces", 4],
10-
"quotemark": [true, "single", "avoid-escape"]
10+
"quotemark": [true, "single", "avoid-escape"],
11+
"member-access": [true, "no-public"]
1112
},
1213
"rulesDirectory": []
1314
}

0 commit comments

Comments
 (0)