Skip to content
This repository was archived by the owner on Dec 26, 2024. It is now read-only.
This repository was archived by the owner on Dec 26, 2024. It is now read-only.

Incorrect error massage from getRequest function #32

@dibrovadev

Description

@dibrovadev

Error that comes from proxy.eth_sendRawTransaction has incorrect error message

When I try to log error or use simple console.log, receive:

Error: [object Object]
at node_modules/etherscan-api/lib/get-request.js:44:25
{ not useful for this issue stack trace here }

getRequest method:

  function getRequest(query) {
    return new Promise(function(resolve, reject) {
      client.get('/api?' + query).then(function(response) {
        var data = response.data;

        console.log(data);
        if (data.status && data.status != 1) {
          return reject(data.message);
        }

        if (data.error) {
          return reject(new Error(data.error));
        }
        resolve(data);
      }).catch(function(error) {
        return reject(new Error(error));
      });
    });
  }

this is error structure example:

{ 
   jsonrpc: '2.0',
   error: 
    { 
      code: -32010,
      message: 'Transaction with the same hash was already imported.' 
   },
   id: 1 
}

Line with problem:

    if (data.error) {
          return reject(new Error(data.error));
        }

Error class constructor expects message string as first argument

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions