-
Notifications
You must be signed in to change notification settings - Fork 34
Refactor nav header #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor nav header #769
Conversation
…pdown menu Co-authored-by: Alexander Popov <alex.wayfer@gmail.com>
I don't understand what is on 1st and 5th screenshots, there is a bar with cross like menu is expanded but without menu itself. |
I think the bar doesn't expand. It's just that the "object show" page adds in a list of links that's not present on other pages. I haven't read the code yet though. So screenshot 3 is when you load a page. 6 is the menu expanded on the objects show page. 1 is the menu expanded on all other pages. |
Oh, OK, I got it, thanks. |
@AlexWayfer @natematykiewicz Did you have any feedback about the design/UI? I'm keen to merge, but I wanted to check before hitting the button. |
I haven't pulled it up to "feel" it, but the screenshots seem good and intuitive to me. I think the only reason there was confusion in this thread is because the order the screenshots were uploaded in isn't the order you'd actually experience the site in. Ship it! 🚀 |
Thanks for the feedback. Next time I'll be sure to make it a lot more clearer. |
I see you deployed it. Feels good to me. Nice work! |
I confused with at least 2 things:
Also I'm not sure what to do with #389 now. |
Perhaps the logo and hamburger should be moved so they're directly under where the menu shows them, so they don't shift around? |
I've also noticed the sun/moon is a little low. It's not quite vertically centered. |
This PR refactors the navigation to allow mobile users to perform the same options as desktop users, ie: Toggle theme & select Ruby Version.
Some things I still want to do:
Supersedes #389
Closes #291
Screenshots: