Skip to content

Improve methods types styles #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexWayfer
Copy link
Contributor

Resolve #382 (comment)

@colby-swandale
Copy link
Member

colby-swandale commented Sep 10, 2020

Thank you for working on the PR but unfortunately i don't agree with this change. The method title/call sequence is one of the first things users look at & want to see when arriving on the page, we want these headers to be super easy to distinguish from everything else. Making the headers smaller makes it blend in more easily with method descriptions and harder to distinguish for users.

@AlexWayfer
Copy link
Contributor Author

Small note: I've checked default sizes for HTML headers and compared to Tailwind, there are they:

HTML Tailwind
<h1>, 2em .text-3xl, 1.875rem
<h2>, 1.5em .text-2xl, 1.5rem
<h3>, 1.17em .text-xl, 1.25rem
<h4>, 1em .text-lg, 1.125rem

So… they're different, but look approximately equal.

Also we have text-4xl with 2.25rem and can use headers starting from it.

@natematykiewicz
Copy link
Contributor

@colby-swandale did you see my comment on the "split class and instance methods" that this PR is trying to resolve? I haven't loaded this PR up, so I can't comment on that, but something really should change compared to master.

@colby-swandale
Copy link
Member

Sorry @natematykiewicz, I did see the comment but didn't get around to replying. I agree that something needs to change between the section titles & method titles, but i am hesitant to change the method title styles as they are - in my mind - one of the most important things to the user on the page.

The solution in my view is to do something similar that I did in #382 (comment) and have the section headers styled differently & spaced far between method headers.

@colby-swandale
Copy link
Member

Sorry I should also say that I am open to other ideas, but I am just hesitant to change the current style of the method headers unless there is a clear benefit for the user.

@natematykiewicz
Copy link
Contributor

Can someone post a screenshot of what this PR looks like before and after?

@AlexWayfer
Copy link
Contributor Author

Can someone post a screenshot of what this PR looks like before and after?

Current master:

image

This PR:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants