Skip to content

Add (toggleable) sidebar for small screens #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexWayfer
Copy link
Contributor

Resolve #291

@AlexWayfer AlexWayfer force-pushed the add_sidebar_for_small_screens branch from 198c0db to 704db11 Compare April 21, 2020 14:09
@AlexWayfer
Copy link
Contributor Author

@colby-swandale, please, can you review this PR?

@colby-swandale
Copy link
Member

colby-swandale commented Sep 1, 2020

Apologies for not responding to this. I am in the middle of redesigning the header that will have a popout sidebar menu system like this for mobile. I will probably merge this PR into that work and will let you know when I raise a PR.

@AlexWayfer AlexWayfer force-pushed the add_sidebar_for_small_screens branch from 704db11 to 95c7645 Compare September 8, 2020 22:48
@AlexWayfer
Copy link
Contributor Author

Apologies for not responding to this. I am in the middle of redesigning the header that will have a popout sidebar menu system like this for mobile. I will probably merge this PR into that work and will let you know when I raise a PR.

  1. I think we should have a better communication which will allow us to not make the same changes, as it was with Patches for Dark mode V2 #357 and can be here.
  2. I see no problem to merge this PR firstly, then make "redesigning" later. Do you see any?

BTW, PR has been rebased (conflicts resolved).

@AlexWayfer AlexWayfer force-pushed the add_sidebar_for_small_screens branch from 95c7645 to e5396a9 Compare September 8, 2020 22:53
@AlexWayfer
Copy link
Contributor Author

object.constant has been added to the top of sidebar (for clarity).

@AlexWayfer AlexWayfer force-pushed the add_sidebar_for_small_screens branch from e5396a9 to 9bb3df6 Compare September 9, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing of Methods Visible on Mobile
2 participants