Support current alias
#1426
Support current alias
#1426
Conversation
config/routes.rb
Outdated
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| ruby_versions = RubyConfig.ruby_versions.collect { |v| Regexp.escape(v.version) } | |||
|
|
|||
| scope "(:version)", constraints: { version: /#{ruby_versions.join("|")}/ } do | |||
| scope "(:version)", constraints: { version: /#{ruby_versions.join("|")}|latest/ } do | |||
There was a problem hiding this comment.
Since RubyConfig.version_for("current") would return nil, no other change is needed.
There was a problem hiding this comment.
I would prefer to not rely on an unspecified rule as the way to support this feature. It's hard for anyone reading the code for the first time to understand this and it's very easy to break unintentionally. I think we should have a special case for current and be able to handle it transparently.
|
Updated to use |
|
I've not pulled this up locally yet, but do all of the links display as "current" or "3.2" when you pull up "current" documentation? |
|
As "3.2" |
|
That seems fine for now. Maybe later we can support making those say "current", so that your documentation links don't lose that. For example here: |
I feel this PR is not really complete without this. It's great that we're allowing Could we also have some tests to ensure this feature is working as intended? Thanks. |
|
This would be great for something like a DuckDuckGo bang to search the docs. FWIW, in that scenario it wouldn't be a problem for me personally if the links referred to the specific version 👍 |
From the suggestion in #1417 (comment)
I thinkcurrentwould be clearer though.latestmight be interpreted as the latest commit onmaster.Closes #1215