Probably we should not expose dependencies ports at all?

Probably we should not expose dependencies ports at all?

What do you mean?

Probably we should not expose dependencies ports at all?

What do you mean?

As I know, we can delete these ports exposing and they (services) will be available under nicknames let's say (like redis:6379, etc.) if they've started by docker-compose.

But… as I see, the web application is not in Docker (including compose). I think we should move at this direction. But I know 0 about production.

And, at this moment. I'm unable to work on RubyAPI just because it's trying to expose (default) ports which are already bind (by system packages).

Production is Heroku, using the Procfile and whatever ENV vars @colby-swandale has configured. I wouldn't change any production configs. Colby configures those.

Heroku can deal with docker-compose: https://devcenter.heroku.com/articles/local-development-with-docker-compose

Like, we need for a service like web there.

I'll wait for some comments from @colby-swandale, no problem.

👋🏻 Docker was mostly just a personal preference when I started the project; it's easy to document & start/reset with a few simple commands. Though Docker is the "blessed" method that Ruby API will work with out of the box, If you prefer your OS package manager, that's perfectly fine and should work without issue. I like happy developers over enforcing ways of working.

I don't desire a web service in Docker Compose. I always run rails/node/python applications outside Docker, so adding that service will be disruptive when I run docker compose up. I will happily support a docker-compose.web.yml file with a web service for people who prefer to run Rails inside Docker.

I don't desire a web service in Docker Compose. I always run rails/node/python applications outside Docker, so adding that service will be disruptive when I run docker compose up.

May I know why? Just curious.

I will happily support a docker-compose.web.yml file with a web service for people who prefer to run Rails inside Docker.

Sounds like not a difficult change, I'll try.

I will happily support a docker-compose.web.yml file with a web service for people who prefer to run Rails inside Docker.

Sounds like not a difficult change, I'll try.

Update: it'll require changes like this:

-  url: <%= ENV.fetch("REDIS_SESSION_URL") { "redis://localhost:6379/1" } %>
+  url: <%= ENV.fetch("REDIS_SESSION_URL") { "redis://redis:6379/1" } %>

And I don't think it'll work for you.

I'm closing this PR for now, but feel free to open a new PR with rebase if you would like to see this merged in the future.