let's assume folks will have to modify /etc/hosts

vroldanbet · vroldanbet · commit 1b595b2148e1 · 2019-11-14T12:03:13.000+01:00
it's a little price to pay in the current setup and allows us to
have the same tests locally and dev.
diff --git a/test/integration/test_bind.rb b/test/integration/test_bind.rb
@@ -151,13 +151,9 @@ def test_bind_tls_with_bogus_hostname_system_ca_fails
     )
   end
 
-  # The following depend on /etc/hosts hacking.
-  # We can do that on CI, but it's less than cool on people's dev boxes
   def test_bind_tls_with_multiple_hosts
-    omit_unless ENV['TRAVIS'] == 'true'
-
     @ldap.host = nil
-    @ldap.hosts = [['ldap01.example.com', 389], ['ldap02.example.com', 389]]
+    @ldap.hosts = [[INTEGRATION_HOSTNAME, 389], [INTEGRATION_HOSTNAME, 389]]
     @ldap.encryption(
       method:      :start_tls,
       tls_options: TLS_OPTS.merge(verify_mode: OpenSSL::SSL::VERIFY_PEER,
@@ -168,8 +164,6 @@ def test_bind_tls_with_multiple_hosts
   end
 
   def test_bind_tls_with_multiple_bogus_hosts
-    omit_unless ENV['TRAVIS'] == 'true'
-
     @ldap.host = nil
     @ldap.hosts = [['127.0.0.1', 389], ['bogus.example.com', 389]]
     @ldap.encryption(
@@ -186,8 +180,6 @@ def test_bind_tls_with_multiple_bogus_hosts
   end
 
   def test_bind_tls_with_multiple_bogus_hosts_no_verification
-    omit_unless ENV['TRAVIS'] == 'true'
-
     @ldap.host = nil
     @ldap.hosts = [['127.0.0.1', 389], ['bogus.example.com', 389]]
     @ldap.encryption(
