Do not add controls when it is empty. Fixed #17

doitian · prathe · commit 05640940bca2 · 2011-10-20T13:45:15.000-04:00
Some LDAP servers, such as ApacheDS, consider as invalid protocol, if controls
is an empty array.
diff --git a/lib/net/ldap.rb b/lib/net/ldap.rb
@@ -1394,9 +1394,9 @@ def search(args = {})
           false.to_ber,
           rfc2696_cookie.map{ |v| v.to_ber}.to_ber_sequence.to_s.to_ber
         ].to_ber_sequence if paged_searches_supported
-      controls = controls.to_ber_contextspecific(0)
+      controls = controls.empty? ? nil : controls.to_ber_contextspecific(0)
 
-      pkt = [next_msgid.to_ber, request, controls].to_ber_sequence
+      pkt = [next_msgid.to_ber, request, controls].compact.to_ber_sequence
       @conn.write pkt
 
       result_code = 0
