ZJIT: Remove unneeded test exclusions #13918
Merged
+5
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
zjit-remove-unneeded-test-exclusion
branch
from
1dbe725 to
1a9db0f
Compare
st0012
changed the title
After several ZJIT fix PRs, the number of failing/crashing tests for ZJIT has dropped significantly. This removes the unneeded test exclusions.
st0012
force-pushed
the
zjit-remove-unneeded-test-exclusion
branch
from
c5fe06e to
975d677
Compare
st0012
commented
Jul 16, 2025
| @@ -42,7 +42,7 @@ jobs: | |||
|
|
|||
| - test_task: 'zjit-test-all' | |||
| configure: '--enable-zjit=dev' | |||
| testopts: '--seed=11831' | |||
| testopts: '--seed=18140' | |||
There was a problem hiding this comment.
With different tests running, ubuntu now needs a different seed to pass.
The old seed was causing this crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several ZJIT fix PRs, the number of failing/crashing tests for ZJIT has dropped significantly. This removes the unneeded test exclusions.