Skip to content

Make Pathname to embedded class #13873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

Make Pathname to embedded class #13873

merged 2 commits into from
Jul 15, 2025
+263 −105

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jul 14, 2025

@hsbt hsbt force-pushed the make-pathname-core-class branch from 4a248c5 to 0a070bd Compare July 14, 2025 09:12
@hsbt
Copy link
Member Author

hsbt commented Jul 14, 2025

https://github.com/ruby/ruby/actions/runs/16262831224/job/45913323438?pr=13873 is not related this change.

    1) Error:
  URI::TestMailTo#test_email_regexp:
  Test::Unit::ProxyError: [1000]: in 1.7561469934922131s (tmin: 0.00027183400000002633, tmax: 0.0008036670000000079, tbase: 0.017561469934922132)
      /Users/runner/work/ruby/ruby/src/test/uri/test_mailto.rb:223:in 'block (2 levels) in URI::TestMailTo#test_email_regexp'
      /Users/runner/work/ruby/ruby/src/test/uri/test_mailto.rb:223:in 'Integer#times'
      /Users/runner/work/ruby/ruby/src/test/uri/test_mailto.rb:223:in 'block in URI::TestMailTo#test_email_regexp'

@hsbt
Copy link
Member Author

hsbt commented Jul 14, 2025

We should migrate lib/pathname.rb to pathname.rbinc without external dependency like find, fileutils.

@hsbt hsbt force-pushed the make-pathname-core-class branch from 0a070bd to ad2a939 Compare July 15, 2025 00:01
@launchable-app Launchable app

This comment has been minimized.

Sign in to view
@hsbt hsbt force-pushed the make-pathname-core-class branch 2 times, most recently from 43e9702 to 7c23fb6 Compare July 15, 2025 00:37
@hsbt hsbt force-pushed the make-pathname-core-class branch from 7c23fb6 to 3fbfa35 Compare July 15, 2025 01:02
@hsbt hsbt merged commit 8794406 into ruby:master Jul 15, 2025
98 of 104 checks passed
@hsbt hsbt deleted the make-pathname-core-class branch July 15, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @nobu