[DOC] Tweaks for String#count #13839
Conversation
doc/string/count.rdoc
Outdated
| s.count('abc', 'def') # => 0 | ||
| s.count('') # => 0 | ||
|
|
||
| Selectors may include negations, ranges, and escapes: |
There was a problem hiding this comment.
What do you mean by "escapes"? Like "\n"? That's a feature of the string rather than String#count.
There was a problem hiding this comment.
Not sure what "escapes" is supposed to mean. It's mentioned in the previous documentation, though. What do you thinki?
There was a problem hiding this comment.
Looking at the original documentation, it means escaping the special characters like ^ and -
"1^2^3".count("\\^1") # => 3
"^-^".count("\\^\\-") # => 3
|
@peterzhu2118, on second thought, maybe it's better to retain file Maybe review that file for possible improvements, and add/revise the examples in its nine referring methods? If agreed, I'll close this PR. |
|
It's your call, but I think there's only 3 other places that use it ( |
|
I'm rethinking this. |
|
Re-rethinking this. And marking as draft. |
I'd like to get rid of file
doc/character_selectors.rdoc. I think it's better for the methods' documentation to handle things on their own (as I've shown here).Right now, it's also referred to at:
#delete/delete!.#squeeze/#squeeze!.When these are all 'tweaked', those references will be gone and we can delete the file.