Extract arith_seq_take #13730
Merged
Extract arith_seq_take #13730
+48
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrkn Please let me know if you have any feedback! |
|
@sferik Thank you very much! |
mrkn
force-pushed
the
extract-arith_seq_take
branch
from
da8455e to
4fa0306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the logic for fetching multiple elements from an arithmetic sequence into a new helper function
arith_seq_take. Nowarith_seq_firstdelegates toarith_seq_takewhen an argument is provided.Fixes a TODO added in 2019 by @mrkn.