-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[Do not merge] wbcheck: Experimental pluggable GC to detect missing write barriers #13557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jhawthorn
wants to merge
70
commits into
ruby:master
Choose a base branch
from
jhawthorn:wbcheck
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,581
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2025
This was referenced Jun 17, 2025
❌ Tests Failed✖️no tests failed ✔️55836 tests passed(16 flakes) |
This was referenced Jun 17, 2025
This reverts commit 1ca55f5.
I don't remember if this was necessary
Because TypedData_Make_Struct both allocates an object and after xmallocs memory, all added references must always be writebarrier protected.
This commit adds support for the MethodRedefined invariant to be invalidated when a method is redefined. Changes: - Added CME pointer to the MethodRedefined invariant in HIR - Updated all places where MethodRedefined invariants are created to include the CME pointer - Added handling for MethodRedefined invariants in gen_patch_point to call track_cme_assumption, which registers the patch point for invalidation when rb_zjit_cme_invalidate is called This ensures that when a method is redefined, all JIT code that depends on that method will be properly invalidated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
I will not be merging this, at least not any time soon. Not looking for code review, just sharing an experiment early in its development.
I've been working on a tool to help detect missed write barriers more reliably. This is one of the most common, yet for a WB bug to actually surface it requires very specific conditions so it's hard to tell when one exists or even has been fixed.
The basic algorithm is:
a.references = reachable_objects_from(a)
a -> b
-a.references << b
(reachable_objects_from(a) - a.references).empty?
, otherwise we've missed a write barrierI've implemented this by writing a new pluggable GC just for testing and debugging, which applies these checks to every object. These rules might be more strict than the default GC requires, for example WBs that could only happen from young to old objects, however I think it will more reliably reproduce issues. For example this has found a few cases where
initialize
/initialize_copy
was missing write barriers, which is unlikely to cause an issue in practice, but one couldObject.allocate
an object, let it get old, and thenobj.send(:initialize, young_reference)
to cause a crash. I think we should follow the stricter rules to ensure we don't miss any write barriers and to avoid assumptions about the GC implementation.Example usage (finding a real bug in Set! See #13558):
Limitations:
make btest
has about 4 bugs.make test-all
shows a lot of problems, some are likely false positives, but I've found a few seemingly legitimate issues.