Skip to content

feat: Allow users to give override AI connector #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: Allow users to give override AI connector #7606

wants to merge 3 commits into from
+226 −17

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Jul 10, 2025 •
edited
Loading

Subtask : https://linear.app/rilldata/issue/PLAT-107/setup-more-ai-abstractions-in-the-runtime

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul changed the title migrate ai code to runtime/pkg feat: Allow users to give override AI connector Jul 18, 2025
@k-anshul k-anshul marked this pull request as ready for review July 18, 2025 13:55
@k-anshul k-anshul self-assigned this Jul 18, 2025
k-anshul
k-anshul commented Jul 18, 2025
View reviewed changes
runtime/pkg/ai/ai.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is uncommon in our code to use API proto structs in runtime/pkg but it is something that gets the work done quickest.

@k-anshul k-anshul marked this pull request as draft July 18, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller Awaiting requested review from begelundmuller

@ericpgreen2 ericpgreen2 Awaiting requested review from ericpgreen2

At least 1 approving review is required to merge this pull request.

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k-anshul