Skip to content

Js.Dict.t -> dict #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Js.Dict.t -> dict #822

merged 1 commit into from
Dec 10, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Dec 10, 2024

No description provided.

@cknitt cknitt requested a review from Freddy03h December 10, 2024 09:39
@Freddy03h
Copy link
Member

You want to remove all ref to Js module before the 0.75 release?

@cknitt
Copy link
Member Author

cknitt commented Dec 10, 2024

Where possible, yes.
There may be some follow-up PRs to this one. 🙂

@Freddy03h
Copy link
Member

Ok, and you also want to add Core ?

@cknitt
Copy link
Member Author

cknitt commented Dec 10, 2024

No, this would be hard, because right now it is an extra dependency, but in v12 it will be part of the rescript npm package.

@cknitt cknitt merged commit 5141687 into main Dec 10, 2024
2 checks passed
@cknitt cknitt deleted the dict branch December 10, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants