feature: log an error message when srcache_store subrequest has an error or returns a bad http status code. thanks Yann Coleu for the report.

agentzh · agentzh · commit 05bc2cb98851 · 2014-07-04T14:12:01.000-07:00
diff --git a/src/ngx_http_srcache_store.c b/src/ngx_http_srcache_store.c
@@ -644,6 +644,15 @@ static ngx_int_t
 ngx_http_srcache_store_post_subrequest(ngx_http_request_t *r, void *data,
     ngx_int_t rc)
 {
+    if (rc == NGX_ERROR
+        || rc >= NGX_HTTP_SPECIAL_RESPONSE
+        || r->headers_out.status >= NGX_HTTP_SPECIAL_RESPONSE)
+    {
+        ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
+                      "srcache_store subrequest failed: rc=%i status=%ui",
+                      rc, r->headers_out.status);
+    }
+
     return NGX_OK;
 }
 
diff --git a/t/bugs.t b/t/bugs.t
@@ -547,8 +547,8 @@ finalize: 0
 Content-Type: text/css
 --- response_body
 I do like you
---- no_error_log
-[error]
+--- error_log
+srcache_store subrequest failed: rc=-1 status=0
 
 
 
@@ -600,8 +600,8 @@ finalize: 0
 Content-Type: text/css
 --- response_body
 I do like you
---- no_error_log
-[error]
+--- error_log
+srcache_store subrequest failed: rc=500 status=0,
 
 
 
@@ -629,3 +629,41 @@ srcache_fetch: cache sent truncated response body
 --- no_error_log
 [alert]
 
+
+
+=== TEST 18: store subrequest failure
+--- http_config
+    upstream local {
+        server localhost:$TEST_NGINX_MEMCACHED_PORT;
+    }
+
+--- config
+    memc_connect_timeout 100ms;
+    memc_send_timeout 100ms;
+    memc_read_timeout 100ms;
+
+    location = /memc {
+        internal;
+
+        set $memc_key $query_string;
+        set $memc_exptime 1d;
+        memc_pass local;
+    }
+
+    location = /tblah {
+        srcache_fetch GET /memc $uri;
+        srcache_store PUT /memc $uri;
+        proxy_pass http://127.0.0.1:$server_port/back;
+    }
+
+    location = /back {
+        echo ok;
+    }
+--- request
+    GET /tblah
+--- response_body
+ok
+--- error_log
+variable "$memc_exptime" takes invalid value: 1d,
+srcache_store subrequest failed: rc=400 status=0,
+
