Merge pull request codeIIEST#34 from manojkun/master

prateekiiest · web-flow · commit 7bf0cc43a391 · 2017-12-01T12:08:17.000+05:30
Made minor changes
diff --git a/README.md b/README.md
@@ -59,7 +59,7 @@ From [Wikipedia][quick-wiki]: Quicksort (sometimes called partition-exchange sor
 __Properties__
 * Worst case performance	O(n^2)
 * Best case performance	O(n log n) or O(n) with three-way partition
-* Average case performance	O(n^2)
+* Average case performance	O(n log n)
 
 ###### View the algorithm in [action][quick-toptal]
 
diff --git a/search/Binary_Search.c b/search/Binary_Search.c
@@ -21,7 +21,7 @@ int main() {
  top = n_terms;
  
  do {
-  mid = (bottom + top) / 2;
+  mid = bottom +  (top - bottom)/2 ; // same as (bottom + top / 2) but considers overflow condition when bottom + top might be larger than int 
   if (item < arr[mid])
    top = mid - 1;                            // Here we are dividing the array into two equal parts 
   else if (item > arr[mid])                   /* if target element > mid part of array , we do the search in the upper part of the array
diff --git a/sort/bubble_sort.c b/sort/bubble_sort.c
@@ -3,13 +3,14 @@
 
 #include <stdio.h>
 
+void swap(int*,int*);
 
 void bubblesort(int arr[], int size)
 {
     int i, j;
-    for (i = 0;  i < size; i++)     //  Function where the actual algorithm is implemented
+    for (i = 0;  i < size - 1; i++)     //  Function where the actual algorithm is implemented
     {
-        for (j = 0; j < size - i; j++)
+        for (j = 0; j < size - i - 1; j++)
         {
             if (arr[j] > arr[j+1])
                 swap(&arr[j], &arr[j+1]);
@@ -39,6 +40,7 @@ int main()
  
     for (i = 0; i < size; i++)
         printf(" %d ", array[i]);
+    printf(" ");
     return 0;
  
 }
diff --git a/sort/insertion_sort.c b/sort/insertion_sort.c
@@ -16,7 +16,7 @@ int main(){
   for(i=1;i<s;i++){
       temp=a[i];
       j=i-1;
-      while((temp<a[j])&&(j>=0)){
+      while((j>=0) && (temp<a[j])){
       a[j+1]=a[j];
           j=j-1;
       }

Original file line number	Diff line number	Diff line change
`@@ -3,13 +3,14 @@`
`3`	`3`
`4`	`4`	`#include <stdio.h>`
`5`	`5`
	`6`	`+void swap(int,int);`
`6`	`7`
`7`	`8`	`void bubblesort(int arr[], int size)`
`8`	`9`	`{`
`9`	`10`	`int i, j;`
`10`		`- for (i = 0; i < size; i++) // Function where the actual algorithm is implemented`
	`11`	`+ for (i = 0; i < size - 1; i++) // Function where the actual algorithm is implemented`
`11`	`12`	`{`
`12`		`- for (j = 0; j < size - i; j++)`
	`13`	`+ for (j = 0; j < size - i - 1; j++)`
`13`	`14`	`{`
`14`	`15`	`if (arr[j] > arr[j+1])`
`15`	`16`	`swap(&arr[j], &arr[j+1]);`
`@@ -39,6 +40,7 @@ int main()`
`39`	`40`
`40`	`41`	`for (i = 0; i < size; i++)`
`41`	`42`	`printf(" %d ", array[i]);`
	`43`	`+ printf(" ");`
`42`	`44`	`return 0;`
`43`	`45`
`44`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ int main(){`
`16`	`16`	`for(i=1;i<s;i++){`
`17`	`17`	`temp=a[i];`
`18`	`18`	`j=i-1;`
`19`		`- while((temp<a[j])&&(j>=0)){`
	`19`	`+ while((j>=0) && (temp<a[j])){`
`20`	`20`	`a[j+1]=a[j];`
`21`	`21`	`j=j-1;`
`22`	`22`	`}`