Skip to content

Commit d5d706b

Browse files
authored
Merge pull request intercom#152 from jkeyes/count-tidy
Removing unused `count` api operation.
2 parents d5fdac6 + b85ce26 commit d5d706b

File tree

5 files changed

+5
-40
lines changed

5 files changed

+5
-40
lines changed

CHANGES.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
Changelog
22
=========
3-
3+
* 3.0.3
4+
* Removed `count` API operation, this is supported via `client.counts` now. (`#152 <https://github.com/jkeyes/python-intercom/pull/152>`_)
45
* 3.0.2
56
* Added multipage support for Event.find_all. (`#147 <https://github.com/jkeyes/python-intercom/pull/147>`_)
67
* 3.0.1

intercom/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
MultipleMatchingUsersError, RateLimitExceeded, ResourceNotFound,
77
ServerError, ServiceUnavailableError, UnexpectedError, TokenUnauthorizedError)
88

9-
__version__ = '3.0.2'
9+
__version__ = '3.0.3'
1010

1111

1212
RELATED_DOCS_TEXT = "See https://github.com/jkeyes/python-intercom \

intercom/api_operations/count.py

Lines changed: 0 additions & 15 deletions
This file was deleted.

intercom/count.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,8 @@
11
# -*- coding: utf-8 -*-
2+
"""Count Resource."""
23

34
from intercom.traits.api_resource import Resource
45

56

67
class Count(Resource):
7-
pass
8-
9-
# @classmethod
10-
# def fetch_for_app(cls):
11-
# return Count.find()
12-
13-
# @classmethod
14-
# def do_broken_down_count(cls, entity_to_count, count_context):
15-
# result = cls.fetch_broken_down_count(entity_to_count, count_context)
16-
# return getattr(result, entity_to_count)[count_context]
17-
18-
# @classmethod
19-
# def fetch_broken_down_count(cls, entity_to_count, count_context):
20-
# return Count.find(type=entity_to_count, count=count_context)
8+
"""Collection class for Counts."""

intercom/service/count.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,3 @@ def for_app(self):
1616

1717
def for_type(self, type, count=None):
1818
return self.find(type=type, count=count)
19-
20-
# @classmethod
21-
# def do_broken_down_count(cls, entity_to_count, count_context):
22-
# result = cls.fetch_broken_down_count(entity_to_count, count_context)
23-
# return getattr(result, entity_to_count)[count_context]
24-
25-
# @classmethod
26-
# def fetch_broken_down_count(cls, entity_to_count, count_context):
27-
# return Count.find(type=entity_to_count, count=count_context)

0 commit comments

Comments
 (0)