Fix analyzer for array creation handling and deactivate return handling

filmor · filmor · commit 721db452cc08 · 2021-11-13T17:06:44.000+01:00
diff --git a/src/noncopyable_analyzer/NonCopyableAnalyzer.cs b/src/noncopyable_analyzer/NonCopyableAnalyzer.cs
@@ -57,13 +57,13 @@ public override void Initialize(AnalysisContext context)
                     CheckCopyability(oc, op.Value, ArgumentRule);
                 }, OperationKind.Argument);
 
-                csc.RegisterOperationAction(oc =>
-                {
-                    var op = (IReturnOperation)oc.Operation;
-                    if (op.ReturnedValue == null) return;
-                    CheckCopyability(oc, op.ReturnedValue, ReturnRule);
-                }, OperationKind.Return,
-                OperationKind.YieldReturn);
+                // csc.RegisterOperationAction(oc =>
+                // {
+                //     var op = (IReturnOperation)oc.Operation;
+                //     if (op.ReturnedValue == null) return;
+                //     CheckCopyability(oc, op.ReturnedValue, ReturnRule);
+                // }, OperationKind.Return,
+                // OperationKind.YieldReturn);
 
                 csc.RegisterOperationAction(oc =>
                 {
@@ -93,7 +93,7 @@ public override void Initialize(AnalysisContext context)
                 {
                     var op = (IArrayInitializerOperation)oc.Operation;
 
-                    if (!((IArrayTypeSymbol)((IArrayInitializerOperation)op.Parent).Type).ElementType.IsNonCopyable()) return;
+                    if (!((IArrayTypeSymbol)((IArrayCreationOperation)op.Parent).Type).ElementType.IsNonCopyable()) return;
 
                     foreach (var v in op.ElementValues)
                     {
